Groups > linux.kernel > #1319141

Re: [PATCH V8 20/23] perf tools: making function set_max_cpu_num() non static

From	Mathieu Poirier <mathieu.poirier@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V8 20/23] perf tools: making function set_max_cpu_num() non static
Date	2016-01-27 17:30 +0100
Message-ID	<qVB8L-6ft-31@gated-at.bofh.it> (permalink)
References	(2 earlier) <qUWfg-12K-13@gated-at.bofh.it> <qUWIi-1vA-23@gated-at.bofh.it> <qUX1F-1E8-3@gated-at.bofh.it> <qVfhV-7dM-17@gated-at.bofh.it> <qVh0m-8go-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 26 January 2016 at 11:51, Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Em Tue, Jan 26, 2016 at 10:08:21AM -0700, Mathieu Poirier escreveu:
>> On 25 January 2016 at 14:29, Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>> > Em Mon, Jan 25, 2016 at 06:12:42PM -0300, Arnaldo Carvalho de Melo escreveu:
>> >> Em Mon, Jan 25, 2016 at 01:46:22PM -0700, Mathieu Poirier escreveu:
>> >> > On 14 January 2016 at 14:46, Mathieu Poirier <mathieu.poirier@linaro.org> wrote:
>> >> > I can't queue this patch for 4.6 without at least a reviewed by from you.
>> >>
>> >> This one I remember, looks ugly, the name set_max_cpu_num() looks
>> >> strange, when that was restricted (static) to that cpumap.c file, it
>> >> wasn't a problem, exporting it for wider usage looks bad.
>> >>
>> >> You've been waiting for this for quite a while, it seems, lemme stop
>> >> what I am doing to check this...
>> >
>> > So, please check the patch below, what you need then is just to use
>> > cpu__max_cpu().
>>
>> I like your approach - thanks for the review.  I will spin V9 when I
>> have received Adrian's comments.
>
> I'll take that as an Acked-by: and since this improves the current
> situation by hiding needlessly exported global variables, I'll get it in
> now, thanks.

I would have added this code in my patchset with the right authorship
- whatever works best for you.

Thanks,
Mathieu

>
> - Arnaldo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V8 20/23] perf tools: making function set_max_cpu_num()  non static Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-01-25 21:50 +0100
  Re: [PATCH V8 20/23] perf tools: making function set_max_cpu_num()  non static Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-25 22:20 +0100
    Re: [PATCH V8 20/23] perf tools: making function set_max_cpu_num()  non static Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-25 22:40 +0100
      Re: [PATCH V8 20/23] perf tools: making function set_max_cpu_num()  non static Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-01-26 18:10 +0100
        Re: [PATCH V8 20/23] perf tools: making function set_max_cpu_num()  non static Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-26 20:00 +0100
          Re: [PATCH V8 20/23] perf tools: making function set_max_cpu_num()  non static Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-01-27 17:30 +0100

csiph-web