Groups > linux.kernel > #1319067

Re: [RFC][PATCH] mips: Fix arch_spin_unlock()

From	Will Deacon <will.deacon@arm.com>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH] mips: Fix arch_spin_unlock()
Date	2016-01-27 16:30 +0100
Message-ID	<qVAcG-5tw-17@gated-at.bofh.it> (permalink)
References	(2 earlier) <qu4Dw-3VM-1@gated-at.bofh.it> <qu4Dx-3VM-45@gated-at.bofh.it> <qVv3k-1Ak-5@gated-at.bofh.it> <qVwLM-2Tu-23@gated-at.bofh.it> <qVzJE-4Zj-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jan 27, 2016 at 03:54:21PM +0100, Peter Zijlstra wrote:
> On Wed, Jan 27, 2016 at 11:43:48AM +0000, Will Deacon wrote:
> > Do you know whether a SYNC 18 (RELEASE) followed in program order by a
> > SYNC 17 (ACQUIRE) creates a full barrier (i.e. something like SYNC 16)?
> > 
> > If not, you may need to implement smp_mb__after_unlock_lock for RCU
> > to ensure globally transitive unlock->lock ordering should you decide
> > to relax your locking barriers.
> 
> You know that is a tricky question. Maybe its easier if you give the 3
> cpu litmus test that goes with it.

Sure, I was building up to that. I just wanted to make sure the basics
were there (program-order, so same CPU) before we go any further. It
sounds like they are, so that's promising.

> Maciej, the tricky point is what, if any, effect the
> SYNC_RELEASE+SYNC_ACQUIRE pair has on an unrelated CPU. Please review
> the TRANSITIVITY section in Documentation/memory-barriers.txt and
> replace <general barrier> with the RELEASE+ACQUIRE pair.
> 
> We've all (Will, Paul and me) had much 'fun' trying to decipher the
> MIPS64r6 manual but failed to reach a conclusion on this.

For the inter-thread case, Paul had a previous example along the lines
of:


Wx=1
WyRel=1

RyAcq=1
Rz=0

Wz=1
smp_mb()
Rx=0


and I suppose a variant of that:


Wx=1
WyRel=1

RyAcq=1
Wz=1

Rz=1
<address dependency>
Rx=0


Will

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC][PATCH] mips: Fix arch_spin_unlock() "Maciej W. Rozycki" <macro@imgtec.com> - 2016-01-27 11:00 +0100
  Re: [RFC][PATCH] mips: Fix arch_spin_unlock() Will Deacon <will.deacon@arm.com> - 2016-01-27 12:50 +0100
    Re: [RFC][PATCH] mips: Fix arch_spin_unlock() "Maciej W. Rozycki" <macro@imgtec.com> - 2016-01-27 13:50 +0100
    Re: [RFC][PATCH] mips: Fix arch_spin_unlock() Peter Zijlstra <peterz@infradead.org> - 2016-01-27 16:00 +0100
      Re: [RFC][PATCH] mips: Fix arch_spin_unlock() Will Deacon <will.deacon@arm.com> - 2016-01-27 16:30 +0100

csiph-web