Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1319093
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] regmap: mmio: Convert to regmap_bus and fix accessor usage |
| Date | 2016-01-27 17:00 +0100 |
| Message-ID | <qVAFJ-5LQ-21@gated-at.bofh.it> (permalink) |
| References | <qVAml-5zA-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wednesday 27 January 2016 15:34:09 Mark Brown wrote:
> ---
> drivers/base/regmap/regmap-mmio.c | 261 ++++++++++++++++++++------------------
> 1 file changed, 140 insertions(+), 121 deletions(-)
Overall looks good to me, but one bug:
> +
> +#ifdef __64BIT
> +static void regmap_mmio_write64le(struct regmap_mmio_context *ctx,
> + unsigned int reg,
> + unsigned int val)
> +{
> + writeq(val, ctx->regs + reg);
> +}
> +#endif
s/__64BIT/CONFIG_64BIT/
here and in one other line.
Arnd
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] regmap: mmio: Convert to regmap_bus and fix accessor usage Mark Brown <broonie@kernel.org> - 2016-01-27 16:40 +0100 Re: [PATCH] regmap: mmio: Convert to regmap_bus and fix accessor usage Arnd Bergmann <arnd@arndb.de> - 2016-01-27 17:00 +0100 Re: [PATCH] regmap: mmio: Convert to regmap_bus and fix accessor usage Johannes Berg <johannes@sipsolutions.net> - 2016-01-27 17:20 +0100
csiph-web