[PATCH] mmc: sdhci-of-at91: fix pm runtime unbalanced issue in error path

From	Jisheng Zhang <jszhang@marvell.com>
Newsgroups	linux.kernel
Subject	[PATCH] mmc: sdhci-of-at91: fix pm runtime unbalanced issue in error path
Date	2016-01-26 11:50 +0100
Message-ID	<qV9m9-2RQ-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The device power usage counter is increased by pm_runtime_get_noresume
but isn't decreased in err_add_host error path.

Fix this issue by calling pm_runtime_put_noidle() in the error path to
restore the device's power usage counter.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Fixes: f5f17813ae9b ("mmc: sdhci-of-at91: add PM support)
---
 drivers/mmc/host/sdhci-of-at91.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
index 7db7163..3bf6f31 100644
--- a/drivers/mmc/host/sdhci-of-at91.c
+++ b/drivers/mmc/host/sdhci-of-at91.c
@@ -210,7 +210,7 @@ static int sdhci_at91_probe(struct platform_device *pdev)
 
 pm_runtime_disable:
 	pm_runtime_disable(&pdev->dev);
-	pm_runtime_set_suspended(&pdev->dev);
+	pm_runtime_put_noidle(&pdev->dev);
 clocks_disable_unprepare:
 	clk_disable_unprepare(priv->gck);
 	clk_disable_unprepare(priv->mainck);
-- 
2.7.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mmc: sdhci-of-at91: fix pm runtime unbalanced issue in error path Jisheng Zhang <jszhang@marvell.com> - 2016-01-26 11:50 +0100
  Re: [PATCH] mmc: sdhci-of-at91: fix pm runtime unbalanced issue in  error path Ludovic Desroches <ludovic.desroches@atmel.com> - 2016-01-27 17:20 +0100

csiph-web