Re: [PATCH V3 2/2] regulator: mt6323: Add support for MT6323 regulator

From	John Crispin <blogic@openwrt.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V3 2/2] regulator: mt6323: Add support for MT6323 regulator
Date	2016-01-26 12:10 +0100
Message-ID	<qV9Fw-3em-21@gated-at.bofh.it> (permalink)
References	<qUNYm-3kJ-23@gated-at.bofh.it> <qUNYm-3kJ-21@gated-at.bofh.it> <qV9ma-2RQ-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 26/01/2016 11:41, Paul Bolle wrote:
> John,
> 
> On ma, 2016-01-25 at 12:56 +0100, John Crispin wrote:
>> --- /dev/null
>> +++ b/drivers/regulator/mt6323-regulator.c
> 
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
> 
> This states this file is licensed GPL v2 only.
> 
>> +MODULE_LICENSE("GPL");
> 
> And, according to include/linux/module.h, this means "GNU Public License
> v2 or later".
> 
> So I think there's a (subtle) mismatch between the license ident used
> for this driver and the comment above.
> 
> Thanks,
> 
> 
> Paul Bolle
> 

Hi Paul,

thanks, good catch. luckily i had not sent the next version of the
series yet ;)

	John

	John

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V3 2/2] regulator: mt6323: Add support for MT6323 regulator John Crispin <blogic@openwrt.org> - 2016-01-25 13:00 +0100
  Re: [PATCH V3 2/2] regulator: mt6323: Add support for MT6323  regulator Paul Bolle <pebolle@tiscali.nl> - 2016-01-26 11:50 +0100
    Re: [PATCH V3 2/2] regulator: mt6323: Add support for MT6323  regulator John Crispin <blogic@openwrt.org> - 2016-01-26 12:10 +0100

csiph-web