Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1317681

Re: [patch] nvme: lightnvm: buffer overflow in nvme_nvm_identity()

From Matias Bjørling <m@bjorling.me>
Newsgroups linux.kernel
Subject Re: [patch] nvme: lightnvm: buffer overflow in nvme_nvm_identity()
Date 2016-01-26 11:00 +0100
Message-ID <qV8zL-2fZ-5@gated-at.bofh.it> (permalink)
References <qV8gq-28S-5@gated-at.bofh.it>
Organization Paletta

Show all headers | View raw


On 01/26/2016 10:27 AM, Dan Carpenter wrote:
> nvme_nvm_id->ppaf is 4 bytes larger than nvm_id->ppaf.  We're using the
> larger size struct for the sizeof() so we end up corrupting the
> first four bytes of nvm_id->groups[].  It doesn't look like we actually
> want to copy those last bytes anyway.
> 

Thanks, Dan. You are right. The four bytes are overwritten afterwards
and hid the issue.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[patch] nvme: lightnvm: buffer overflow in nvme_nvm_identity() Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-26 10:40 +0100
  Re: [patch] nvme: lightnvm: buffer overflow in nvme_nvm_identity() Matias Bjørling <m@bjorling.me> - 2016-01-26 11:00 +0100

csiph-web