Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1317676

Re: [PATCH v2] ata: add AMD Seattle platform driver

Show all headers | View raw

Hi,

On 25-01-16 21:43, Tejun Heo wrote:
> On Thu, Jan 14, 2016 at 10:31:11AM -0600, Brijesh Singh wrote:
>> AMD Seattle SATA controller mostly conforms to AHCI interface with some
>> special register to control SGPIO interface. In the case of an AHCI
>> controller, the SGPIO feature is ideally implemented using the
>> "Enclosure Management" register of the AHCI controller, but those
>> registeres are not implemented in the Seattle SoC. Instead SoC
>> (Rev B0 onwards) provides a 32-bit SGPIO control register which should
>> be programmed to control the activity, locate and fault LEDs.
>>
>> The driver is based on ahci_platform driver.
>>
>> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
>> Acked-by: Hans de Goede <hdegoede@redhat.com>
>> CC: tj@kernel.org
>> CC: linux-ide@vger.kernel.org
>
> Hans, can you please review the patch?

Done, driver looks good to me:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] ata: add AMD Seattle platform driver Tejun Heo <tj@kernel.org> - 2016-01-25 21:50 +0100
  Re: [PATCH v2] ata: add AMD Seattle platform driver Hans de Goede <hdegoede@redhat.com> - 2016-01-26 10:40 +0100
  Re: [PATCH v2] ata: add AMD Seattle platform driver Arnd Bergmann <arnd@arndb.de> - 2016-01-26 13:20 +0100

csiph-web