Re: [PATCH] media: platform: exynos4-is: media-dev: Add missing of_node_put

From	Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] media: platform: exynos4-is: media-dev: Add missing of_node_put
Date	2016-01-26 10:20 +0100
Message-ID	<qV7X4-1ZG-7@gated-at.bofh.it> (permalink)
References	<qURfB-5VH-35@gated-at.bofh.it> <qUZGa-3xa-1@gated-at.bofh.it> <qV5iy-7WO-13@gated-at.bofh.it> <qV5LA-8nC-1@gated-at.bofh.it> <qV64W-t8-5@gated-at.bofh.it>
Organization	Samsung

Show all headers | View raw

Em Tue, 26 Jan 2016 08:12:15 +0100
Julia Lawall <julia.lawall@lip6.fr> escreveu:

> On Tue, 26 Jan 2016, Krzysztof Kozlowski wrote:
> 
> > On 26.01.2016 15:24, Julia Lawall wrote:  
> > > 
> > > 
> > > On Tue, 26 Jan 2016, Krzysztof Kozlowski wrote:
> > >   
> > >> On 26.01.2016 00:21, Amitoj Kaur Chawla wrote:  
> > >>> for_each_available_child_of_node and for_each_child_of_node perform an
> > >>> of_node_get on each iteration, so to break out of the loop an of_node_put is
> > >>> required.
> > >>>
> > >>> Found using Coccinelle. The simplified version of the semantic patch
> > >>> that is used for this is as follows:
> > >>>
> > >>> // <smpl>
> > >>> @@
> > >>> local idexpression n;
> > >>> expression e,r;
> > >>> @@
> > >>>
> > >>>  for_each_available_child_of_node(r,n) {
> > >>>    ...
> > >>> (
> > >>>    of_node_put(n);
> > >>> |
> > >>>    e = n
> > >>> |
> > >>> +  of_node_put(n);
> > >>> ?  break;
> > >>> )
> > >>>    ...
> > >>>  }
> > >>> ... when != n
> > >>> // </smpl>  
> > >>
> > >> Patch iselft looks correct but why are you pasting coccinelle script
> > >> into the message?
> > >>
> > >> The script is already present in Linux kernel:
> > >> scripts/coccinelle/iterators/device_node_continue.cocci  
> > > 
> > > I don't think so.  The continue one takes care of the case where there is 
> > > an extraneous of_node_put before a continue, not a missing one before a 
> > > break.  But OK to drop it if it doesn't seem useful.
> > > 
> > > julia  
> > 
> > You are right - this is not covered by that cocci patch... but I think
> > is covered by scripts/coccinelle/iterators/fen.cocci, isn't it?  
> 
> Not quite. 

If the script is not part of the Kernel, please keep the script in the
patch, as it could be useful in some future.

Regards,
Mauro

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] media: platform: exynos4-is: media-dev: Add missing  of_node_put Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-01-25 16:30 +0100
  Re: [PATCH] media: platform: exynos4-is: media-dev: Add missing  of_node_put Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-26 01:30 +0100
    Re: [PATCH] media: platform: exynos4-is: media-dev: Add missing  of_node_put Julia Lawall <julia.lawall@lip6.fr> - 2016-01-26 07:30 +0100
      Re: [PATCH] media: platform: exynos4-is: media-dev: Add missing  of_node_put Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-26 08:00 +0100
        Re: [PATCH] media: platform: exynos4-is: media-dev: Add missing  of_node_put Julia Lawall <julia.lawall@lip6.fr> - 2016-01-26 08:20 +0100
          Re: [PATCH] media: platform: exynos4-is: media-dev: Add missing  of_node_put Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2016-01-26 10:20 +0100

csiph-web