Re: [PATCH 2/2] ASoC: s3c24xx: use const snd_soc_component_driver pointer

From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] ASoC: s3c24xx: use const snd_soc_component_driver pointer
Date	2016-01-26 05:10 +0100
Message-ID	<qV373-64e-5@gated-at.bofh.it> (permalink)
References	<qUSOn-7cE-31@gated-at.bofh.it> <qUSY2-7hD-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 26.01.2016 02:07, Arnd Bergmann wrote:
> An older patch to convert the API in the s3c i2s driver
> ended up passing a const pointer into a function that takes
> a non-const pointer, so we now get a warning:
> 
> sound/soc/samsung/s3c2412-i2s.c: In function 's3c2412_iis_dev_probe':
> sound/soc/samsung/s3c2412-i2s.c:172:9: error: passing argument 3 of 's3c_i2sv2_register_component' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
> 
> However, the s3c_i2sv2_register_component() function again
> passes the pointer into another function taking a const, so
> we just need to change its prototype.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: eca3b01d0885 ("ASoC: switch over to use snd_soc_register_component() on s3c i2s")
> ---
>  sound/soc/samsung/s3c-i2s-v2.c | 2 +-
>  sound/soc/samsung/s3c-i2s-v2.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] ASoC: cs35l32: avoid uninitialized variable access Arnd Bergmann <arnd@arndb.de> - 2016-01-25 18:10 +0100
  [PATCH 2/2] ASoC: s3c24xx: use const snd_soc_component_driver pointer Arnd Bergmann <arnd@arndb.de> - 2016-01-25 18:20 +0100
    Re: [PATCH 2/2] ASoC: s3c24xx: use const snd_soc_component_driver  pointer Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-26 05:10 +0100

csiph-web