Re: [PATCH 3/4] arm64: let set_memory_xx(addr, 0) succeed.

From	David Rientjes <rientjes@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/4] arm64: let set_memory_xx(addr, 0) succeed.
Date	2016-01-26 03:40 +0100
Message-ID	<qV1HY-4RV-5@gated-at.bofh.it> (permalink)
References	<qU7Z8-4tS-3@gated-at.bofh.it> <qU7Z8-4tS-1@gated-at.bofh.it> <qUUn8-8cw-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, 25 Jan 2016, Laura Abbott wrote:

> On 01/23/2016 07:05 AM, mika.penttila@nextfour.com wrote:
> > From: Mika Penttilä <mika.penttila@nextfour.com>
> > 
> > This makes set_memory_xx() consistent with x86.
> > 
> > Signed-off-by: Mika Penttilä mika.penttila@nextfour.com
> > 
> > ---
> >   arch/arm64/mm/pageattr.c | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/arch/arm64/mm/pageattr.c b/arch/arm64/mm/pageattr.c
> > index 3571c73..52220dd 100644
> > --- a/arch/arm64/mm/pageattr.c
> > +++ b/arch/arm64/mm/pageattr.c
> > @@ -51,6 +51,9 @@ static int change_memory_common(unsigned long addr, int
> > numpages,
> >   		WARN_ON_ONCE(1);
> >   	}
> > 
> > +	if (!numpages)
> > +		return 0;
> > +
> >   	if (start < MODULES_VADDR || start >= MODULES_END)
> >   		return -EINVAL;
> > 
> > 
> 
> I think this is going to conflict with Ard's patch
> lkml.kernel.org/g/<1453125665-26627-1-git-send-email-ard.biesheuvel@linaro.org>
> 
> Can you rebase on top of that?
> 

Also, I think patch 2 and 3 can be folded together since the change is the 
same to both functions.

I think the changelog should be expanded to explain that 
charge_memory_common() with numpages == 0 should be a no-op.

When both of those are done, and it's rebased as requested, feel free to 
add my:

	Acked-by: David Rientjes <rientjes@google.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/4] arm64: let set_memory_xx(addr, 0) succeed. <mika.penttila@nextfour.com> - 2016-01-23 16:10 +0100
  Re: [PATCH 3/4] arm64: let set_memory_xx(addr, 0) succeed. Laura Abbott <labbott@redhat.com> - 2016-01-25 19:50 +0100
    Re: [PATCH 3/4] arm64: let set_memory_xx(addr, 0) succeed. David Rientjes <rientjes@google.com> - 2016-01-26 03:40 +0100

csiph-web