Re: [PATCH] QE: Use GFP_ATOMIC while spin_lock_irqsave is held

From	Scott Wood <oss@buserror.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] QE: Use GFP_ATOMIC while spin_lock_irqsave is held
Date	2016-01-26 02:00 +0100
Message-ID	<qV09c-3JU-7@gated-at.bofh.it> (permalink)
References	<qUmOu-Wv-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, 2016-01-24 at 12:24 +0530, Saurabh Sengar wrote:
> cpm_muram_alloc_common is called twice and both the times
> spin_lock_irqsave is held.
> Using GFP_KERNEL can sleep in spin_lock_irqsave context and cause
> deadlock
> 
> Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
> ---
> Let me know if there is any other way to fix it.
> Also, I would say this function should be static as it is not used in any
> other file
>  drivers/soc/fsl/qe/qe_common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Yes, it should be static.  Do you plan to send a patch for that?

-Scott

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] QE: Use GFP_ATOMIC while spin_lock_irqsave is held Saurabh Sengar <saurabh.truth@gmail.com> - 2016-01-24 08:00 +0100
  Re: [PATCH] QE: Use GFP_ATOMIC while spin_lock_irqsave is held Scott Wood <oss@buserror.net> - 2016-01-26 02:00 +0100

csiph-web