[PATCH] gpu: host1x: bus: Add missing of_node_put

From	Amitoj Kaur Chawla <amitoj1606@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] gpu: host1x: bus: Add missing of_node_put
Date	2016-01-24 17:40 +0100
Message-ID	<qUvRL-7sW-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

for_each_child_of_node performs an of_node_get on each iteration, so
to break out of the loop an of_node_put is required.

Found using Coccinelle. The semantic patch used for this is as follows:

// <smpl>
@@
expression e;
local idexpression n;
@@

 for_each_child_of_node(..., n) {
   ... when != of_node_put(n)
       when != e = n
(
   return n;
|
+  of_node_put(n);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
 drivers/gpu/host1x/bus.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/host1x/bus.c b/drivers/gpu/host1x/bus.c
index 4a99c64..c1795a2 100644
--- a/drivers/gpu/host1x/bus.c
+++ b/drivers/gpu/host1x/bus.c
@@ -82,8 +82,10 @@ static int host1x_device_parse_dt(struct host1x_device *device,
 		if (of_match_node(driver->subdevs, np) &&
 		    of_device_is_available(np)) {
 			err = host1x_subdev_add(device, np);
-			if (err < 0)
+			if (err < 0) {
+				of_node_put(np);
 				return err;
+			}
 		}
 	}
 
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] gpu: host1x: bus: Add missing of_node_put Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-01-24 17:40 +0100
  Re: [PATCH] gpu: host1x: bus: Add missing of_node_put Thierry Reding <thierry.reding@gmail.com> - 2016-01-25 15:10 +0100

csiph-web