Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1315821

Re: [PATCHSET 0/7] perf tools: Check error during collapsing hist entries

Show all headers | View raw

On Sat, Jan 23, 2016 at 06:01:21PM +0100, Jiri Olsa wrote:
> On Fri, Jan 22, 2016 at 10:41:33PM +0900, Namhyung Kim wrote:
> > Hi,
> > 
> > This patchset checks error case during the process of collapsing hist
> > entries.  It's a preparation of upcoming hierarchy patchset which adds
> > more work in the collapsing path.  If there's an error during this
> > stage, it'll stop processing and show warning to user.
> > 
> > Thanks,
> > Namhyung
> > 
> > 
> > Namhyung Kim (7):
> >   perf callchain: Check return value of add_child()
> >   perf callchain: Check return value of fill_node()
> >   perf callchain: Add enum match_result for match_chain()
> >   perf callchain: Check return value of split_add_child()
> >   perf callchain: Check return value of append_chain_children()
> >   perf hists: Return error from hists__collapse_resort()
> >   perf report: Check error during report__collapse_hists()
> 
> I saw 2 other functions allocating memory and not checked:
>   callchain_cursor_append

Ok, but this function is basically for the 'addition' path.  Well it's
also used by the 'collapsing' path but it never allocates new node
since it reuses the existing ones.  I'll prepare a different patchset
for the 'addition' path later..


>   callchain_node__make_parent_list

It seems not called in the collapsing path.  It should be handled by
a separate patchset.

Thanks,
Namhyung

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHSET 0/7] perf tools: Check error during collapsing hist entries Namhyung Kim <namhyung@kernel.org> - 2016-01-22 14:50 +0100
  [PATCH 1/7] perf callchain: Check return value of add_child() Namhyung Kim <namhyung@kernel.org> - 2016-01-22 14:50 +0100
  [PATCH 2/7] perf callchain: Check return value of fill_node() Namhyung Kim <namhyung@kernel.org> - 2016-01-22 14:50 +0100
  [PATCH 3/7] perf callchain: Add enum match_result for match_chain() Namhyung Kim <namhyung@kernel.org> - 2016-01-22 14:50 +0100
    Re: [PATCH 3/7] perf callchain: Add enum match_result for  match_chain() Jiri Olsa <jolsa@redhat.com> - 2016-01-23 18:10 +0100
      Re: [PATCH 3/7] perf callchain: Add enum match_result for  match_chain() Namhyung Kim <namhyung@kernel.org> - 2016-01-24 05:10 +0100
      [PATCH v2 3/7] perf callchain: Add enum match_result for  match_chain() Namhyung Kim <namhyung@kernel.org> - 2016-01-24 07:00 +0100
  [PATCH 5/7] perf callchain: Check return value of append_chain_children() Namhyung Kim <namhyung@kernel.org> - 2016-01-22 14:50 +0100
  Re: [PATCHSET 0/7] perf tools: Check error during collapsing hist  entries Jiri Olsa <jolsa@redhat.com> - 2016-01-23 18:10 +0100
    Re: [PATCHSET 0/7] perf tools: Check error during collapsing hist  entries Namhyung Kim <namhyung@kernel.org> - 2016-01-24 05:40 +0100
      Re: [PATCHSET 0/7] perf tools: Check error during collapsing hist  entries Jiri Olsa <jolsa@redhat.com> - 2016-01-25 08:20 +0100

csiph-web