Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1315747

[PATCH 1/2] f2fs: avoid multiple node page writes due to inline_data

Show all headers | View raw

The sceanrio is:
1. create fully node blocks
2. flush node blocks
3. write inline_data for all the node blocks again
4. flush node blocks redundantly

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 fs/f2fs/data.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 8d0d9ec..011456e 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -1622,14 +1622,22 @@ static int f2fs_write_end(struct file *file,
 
 	trace_f2fs_write_end(inode, pos, len, copied);
 
-	set_page_dirty(page);
-
 	if (pos + copied > i_size_read(inode)) {
 		i_size_write(inode, pos + copied);
 		mark_inode_dirty(inode);
-		update_inode_page(inode);
 	}
 
+	if (f2fs_has_inline_data(inode) &&
+			is_inode_flag_set(F2FS_I(inode), FI_DATA_EXIST)) {
+		int err = f2fs_write_inline_data(inode, page);
+		if (err)
+			set_page_dirty(page);
+	} else {
+		set_page_dirty(page);
+	}
+
+	f2fs_write_inode(inode, NULL);
+
 	f2fs_put_page(page, 1);
 	f2fs_update_time(F2FS_I_SB(inode), REQ_TIME);
 	return copied;
-- 
2.6.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] f2fs: avoid multiple node page writes due to inline_data Jaegeuk Kim <jaegeuk@kernel.org> - 2016-01-23 21:20 +0100
  RE: [f2fs-dev] [PATCH 1/2] f2fs: avoid multiple node page writes due  to inline_data Chao Yu <chao2.yu@samsung.com> - 2016-01-25 10:50 +0100
    Re: [f2fs-dev] [PATCH 1/2] f2fs: avoid multiple node page writes due  to inline_data Jaegeuk Kim <jaegeuk@kernel.org> - 2016-01-25 20:20 +0100
      RE: [f2fs-dev] [PATCH 1/2] f2fs: avoid multiple node page writes due  to inline_data Chao Yu <chao2.yu@samsung.com> - 2016-01-26 08:10 +0100
        Re: [f2fs-dev] [PATCH 1/2] f2fs: avoid multiple node page writes due  to inline_data Jaegeuk Kim <jaegeuk@kernel.org> - 2016-01-26 19:40 +0100

csiph-web