Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1315741

Re: [PATCH 3/4] tty: serial: 8250: omap: convert to using cyclic transfers

Show all headers | View raw

On 01/22/2016 05:31 PM, Peter Hurley wrote:
> Hi John,
> 
> On 01/22/2016 02:27 AM, John Ogness wrote:
>> Note that an ugly device-tree lookup hack is implemented in order
>> to detect if the sDMA engine is being used. This is necessary
>> because the sDMA driver does not implement pause/resume correctly
>> and therefore requires slightly different logic for the UART
>> driver.
> 
> No, this is not acceptable.
> 
> Please work with Vinod to refine the dma_get_slave_caps() interface
> so that dmaengine drivers that don't provide the _documented_ pause/resume
> support can be identified generically.

But we could implement the pause/resume bits correctly wait until it is
merge and post this and rely on the fact that it works (including error
checking). RMK requested that he wants the UART driver fixed before
touching the DMA driver and this has been done in meantime. So we could
go ahead and add the missing pieces to SDMA.

> Regards,
> Peter Hurley
> 
Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/4] tty: serial: 8250: omap: convert to using cyclic transfers John Ogness <john.ogness@linutronix.de> - 2016-01-22 11:30 +0100
  Re: [PATCH 3/4] tty: serial: 8250: omap: convert to using cyclic  transfers Peter Hurley <peter@hurleysoftware.com> - 2016-01-22 17:40 +0100
    Re: [PATCH 3/4] tty: serial: 8250: omap: convert to using cyclic  transfers Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-01-23 21:20 +0100
      Re: [PATCH 3/4] tty: serial: 8250: omap: convert to using cyclic  transfers Peter Hurley <peter@hurleysoftware.com> - 2016-01-23 22:30 +0100

csiph-web