Re: [PATCH v3 0/4] x86/efi: use binary units when printing

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 0/4] x86/efi: use binary units when printing
Date	2016-01-23 18:30 +0100
Message-ID	<qUaaC-5YV-5@gated-at.bofh.it> (permalink)
References	<qU7Ps-48H-15@gated-at.bofh.it> <qU9of-5ok-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jan 23, 2016 at 6:34 PM, James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
> On Sat, 2016-01-23 at 16:55 +0200, Andy Shevchenko wrote:
>> The patch series exports the arrays of binary and decimal units as
>> it's
>> described by IEC.
>>
>> First user of it is EFI code which would print sizes and other values
>> using
>> binary prefix.
>>
>> James, is this now okay to you?
>
> Patch 2 is still pointless. I happen to like the <tab><space>label:
> convention.

Even there it's just <space>label:

>  I realise others don't but an entire patch simply to
> change my convention to your convention is a bit overkill.

Main point of that patch is to bring snprintf() to one line. Is it
also your style?

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/4] x86/efi: use binary units when printing Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-23 16:00 +0100
  [PATCH v3 2/4] lib/string_helpers: fix indentation in few places Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-23 16:00 +0100
  [PATCH v3 4/4] x86/efi: Use proper units in efi_find_mirror() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-23 16:00 +0100
  [PATCH v3 1/4] lib/string_helpers: export string_units_{2,10} for others Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-23 16:00 +0100
    Re: [PATCH v3 1/4] lib/string_helpers: export string_units_{2,10}  for others James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-01-23 17:20 +0100
      Re: [PATCH v3 1/4] lib/string_helpers: export string_units_{2,10} for others Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-23 18:00 +0100
  Re: [PATCH v3 0/4] x86/efi: use binary units when printing James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-01-23 17:40 +0100
    Re: [PATCH v3 0/4] x86/efi: use binary units when printing Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-23 18:30 +0100

csiph-web