Re: [dm-devel] [PATCH 22/26] iscsi_tcp: Use ahash

From	Mike Christie <michaelc@cs.wisc.edu>
Newsgroups	linux.kernel
Subject	Re: [dm-devel] [PATCH 22/26] iscsi_tcp: Use ahash
Date	2016-01-25 21:00 +0100
Message-ID	<qUVsS-t7-7@gated-at.bofh.it> (permalink)
References	<qUsKd-5k1-3@gated-at.bofh.it> <qUsTV-5op-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/24/2016 07:19 AM, Herbert Xu wrote:
> This patch replaces uses of the long obsolete hash interface with
> ahash.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> ---
> 
>  drivers/scsi/iscsi_tcp.c    |   54 ++++++++++++++++++++++++++------------------
>  drivers/scsi/iscsi_tcp.h    |    4 +--
>  drivers/scsi/libiscsi_tcp.c |   29 +++++++++++++----------
>  include/scsi/libiscsi_tcp.h |   13 +++++-----
>  4 files changed, 58 insertions(+), 42 deletions(-)
> 

iSCSI parts look ok.

Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>

Thread

[PATCH 0/26] crypto: Use skcipher and ahash/shash where possible Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:20 +0100
  [PATCH 8/26] cifs: Use skcipher Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:20 +0100
  [PATCH 11/26] f2fs: Use skcipher Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:20 +0100
  [PATCH 13/26] lib80211: Use skcipher and ahash Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:20 +0100
  [PATCH 1/26] block: cryptoloop - Use new skcipher interface Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:20 +0100
    Re: [PATCH 1/26] block: cryptoloop - Use new skcipher interface kbuild test robot <lkp@intel.com> - 2016-01-24 14:40 +0100
      Re: [PATCH 1/26] block: cryptoloop - Use new skcipher interface Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:50 +0100
  [PATCH 16/26] libceph: Use skcipher Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:20 +0100
    Re: [PATCH 16/26] libceph: Use skcipher Ilya Dryomov <idryomov@gmail.com> - 2016-01-25 17:20 +0100
      Re: [PATCH 16/26] libceph: Use skcipher Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-26 12:00 +0100
        Re: [PATCH 16/26] libceph: Use skcipher Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-26 12:40 +0100
        Re: [PATCH 16/26] libceph: Use skcipher Ilya Dryomov <idryomov@gmail.com> - 2016-01-26 12:40 +0100
  [PATCH 14/26] KEYS: Use skcipher Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:20 +0100
  [PATCH 6/26] staging: rtl8192u: Use skcipher and ahash Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:20 +0100
    Re: [PATCH 6/26] staging: rtl8192u: Use skcipher and ahash Greg KH <greg@kroah.com> - 2016-01-24 21:10 +0100
  [PATCH 3/26] staging: rtl8192e: Replace uses of obsolete blkcipher and hash Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:20 +0100
    Re: [PATCH 3/26] staging: rtl8192e: Replace uses of obsolete  blkcipher and hash Greg KH <greg@kroah.com> - 2016-01-24 21:10 +0100
  [PATCH 5/26] orinoco: Use ahash Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:20 +0100
  [PATCH 24/26] nfsd: Use shash Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:30 +0100
  [PATCH 25/26] sctp: Use shash Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:30 +0100
    Re: [PATCH 25/26] sctp: Use shash David Miller <davem@davemloft.net> - 2016-01-25 07:10 +0100
  [PATCH 10/26] ext4: Use skcipher Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:30 +0100
  [PATCH 18/26] rxrpc: Use skcipher Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:30 +0100
  [PATCH 17/26] mac802154: Use skcipher Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:30 +0100
    Re: [PATCH 17/26] mac802154: Use skcipher Stefan Schmidt <stefan@osg.samsung.com> - 2016-01-26 18:00 +0100
  [PATCH 4/26] dm crypt: Use skcipher and ahash Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:30 +0100
    Re: [PATCH 4/26] dm crypt: Use skcipher and ahash kbuild test robot <lkp@intel.com> - 2016-01-24 14:50 +0100
  [PATCH 22/26] iscsi_tcp: Use ahash Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:30 +0100
    Re: [dm-devel] [PATCH 22/26] iscsi_tcp: Use ahash Mike Christie <michaelc@cs.wisc.edu> - 2016-01-25 21:00 +0100
  [PATCH 26/26] tcp: Use ahash Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:30 +0100
    Re: [PATCH 26/26] tcp: Use ahash David Miller <davem@davemloft.net> - 2016-01-25 07:10 +0100
  [PATCH 23/26] iscsi-target: Use shash and ahash Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:30 +0100
  [PATCH 19/26] ipsec: Use skcipher and ahash when probing algorithms Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:30 +0100
    Re: [PATCH 19/26] ipsec: Use skcipher and ahash when probing  algorithms kbuild test robot <lkp@intel.com> - 2016-01-24 14:50 +0100
    Re: [PATCH 19/26] ipsec: Use skcipher and ahash when probing  algorithms David Miller <davem@davemloft.net> - 2016-01-25 07:10 +0100
  [PATCH 20/26] drbd: Use shash and ahash Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:30 +0100
  [PATCH 21/26] nfc: s3fwrn5: Use shash Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:30 +0100
    Re: [PATCH 21/26] nfc: s3fwrn5: Use shash kbuild test robot <lkp@intel.com> - 2016-01-24 15:00 +0100
  [PATCH 15/26] Bluetooth: Use skcipher and hash Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-24 14:30 +0100
    Re: [PATCH 15/26] Bluetooth: Use skcipher and hash Marcel Holtmann <marcel@holtmann.org> - 2016-01-25 07:50 +0100

csiph-web