Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1317178

Re: [PATCH 6/6] x86/vdso: Use static_cpu_has()

From Andy Lutomirski <luto@amacapital.net>
Newsgroups linux.kernel
Subject Re: [PATCH 6/6] x86/vdso: Use static_cpu_has()
Date 2016-01-25 19:50 +0100
Message-ID <qUUn8-8cw-19@gated-at.bofh.it> (permalink)
References <qUpjj-2Lg-3@gated-at.bofh.it> <qUpjk-2Lg-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sun, Jan 24, 2016 at 1:28 AM, Borislav Petkov <bp@alien8.de> wrote:
> From: Borislav Petkov <bp@suse.de>
>
> ... and simplify and speed up a tad.

This function is only used when initializing CPUs, so the "tad" is
very small indeed.

If there are systems for which some cpus support rdtscp and some
don't, then this patch is wrong.  Of course, if the bsp has rdtscp and
the aps don't, then we're screwed anyway.  I left it as cpu_has
because this is a cpu init function and it seemed reasonable.

That being said, I have no meaningful objection to this patch.

--Andy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 6/6] x86/vdso: Use static_cpu_has() Borislav Petkov <bp@alien8.de> - 2016-01-24 10:40 +0100
  Re: [PATCH 6/6] x86/vdso: Use static_cpu_has() Andy Lutomirski <luto@amacapital.net> - 2016-01-25 19:50 +0100
    Re: [PATCH 6/6] x86/vdso: Use static_cpu_has() Borislav Petkov <bp@alien8.de> - 2016-01-25 20:00 +0100

csiph-web