Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1317116

Re: [PATCH 3/3] dax: Handle write faults more efficiently

Show all headers | View raw

On Mon, Jan 25, 2016 at 9:25 AM, Matthew Wilcox
<matthew.r.wilcox@intel.com> wrote:
> From: Matthew Wilcox <willy@linux.intel.com>
>
> When we handle a write-fault on a DAX mapping, we currently insert a
> read-only mapping and then take the page fault again to convert it to
> a writable mapping.  This is necessary for the case where we cover a
> hole with a read-only zero page, but when we have a data block already
> allocated, it is inefficient.
>
> Use the recently added vmf_insert_pfn_prot() to insert a writable mapping,
> even though the default VM flags say to use a read-only mapping.

Conceptually, I like this.  Do you need to make sure to do all the
do_wp_page work, though?  (E.g. we currently update mtime in there.
Some day I'll fix that, but it'll be replaced with a set_bit to force
a deferred mtime update.)

--Andy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Fixes for vm_insert_pfn_prot() Matthew Wilcox <matthew.r.wilcox@intel.com> - 2016-01-25 18:30 +0100
  [PATCH 2/3] mm: Convert vm_insert_pfn_prot to vmf_insert_pfn_prot Matthew Wilcox <matthew.r.wilcox@intel.com> - 2016-01-25 18:30 +0100
    Re: [PATCH 2/3] mm: Convert vm_insert_pfn_prot to vmf_insert_pfn_prot Andy Lutomirski <luto@amacapital.net> - 2016-01-25 18:40 +0100
      Re: [PATCH 2/3] mm: Convert vm_insert_pfn_prot to vmf_insert_pfn_prot Matthew Wilcox <willy@linux.intel.com> - 2016-01-27 05:20 +0100
  [PATCH 3/3] dax: Handle write faults more efficiently Matthew Wilcox <matthew.r.wilcox@intel.com> - 2016-01-25 18:30 +0100
    Re: [PATCH 3/3] dax: Handle write faults more efficiently Andy Lutomirski <luto@amacapital.net> - 2016-01-25 18:40 +0100
      Re: [PATCH 3/3] dax: Handle write faults more efficiently Matthew Wilcox <willy@linux.intel.com> - 2016-01-27 05:20 +0100
        Re: [PATCH 3/3] dax: Handle write faults more efficiently Andy Lutomirski <luto@amacapital.net> - 2016-01-27 06:30 +0100
        Re: [PATCH 3/3] dax: Handle write faults more efficiently Andy Lutomirski <luto@amacapital.net> - 2016-01-27 07:10 +0100

csiph-web