Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1317047

Re: [PATCH net-next] hv_netvsc: use skb_get_hash() instead of a homegrown implementation

Show all headers | View raw

On Mon, 2016-01-25 at 16:00 +0100, Vitaly Kuznetsov wrote:
> Recent changes to 'struct flow_keys' (e.g commit d34af823ff40 ("net: Add
> VLAN ID to flow_keys")) introduced a performance regression in netvsc
> driver. Is problem is, however, not the above mentioned commit but the
> fact that netvsc_set_hash() function did some assumptions on the struct
> flow_keys data layout and this is wrong.
> 
> Get rid of netvsc_set_hash() by switching to skb_get_hash(). This change
> will also imply switching to Jenkins hash from the currently used Toeplitz
> but it seems there is no good excuse for Toeplitz to stay.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---

Acked-by: Eric Dumazet <edumazet@google.com>

Thanks !

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next] hv_netvsc: use skb_get_hash() instead of a homegrown implementation Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-01-25 16:10 +0100
  Re: [PATCH net-next] hv_netvsc: use skb_get_hash() instead of a  homegrown implementation Eric Dumazet <eric.dumazet@gmail.com> - 2016-01-25 18:10 +0100
  Re: [PATCH net-next] hv_netvsc: use skb_get_hash() instead of a  homegrown implementation David Miller <davem@davemloft.net> - 2016-01-25 20:00 +0100

csiph-web