Re: [PATCH 1/2] [media] m88rs6000t: Better exception handling in five functions

From	Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] [media] m88rs6000t: Better exception handling in five functions
Date	2016-01-25 18:10 +0100
Message-ID	<qUSOn-7cE-33@gated-at.bofh.it> (permalink)
References	(2 earlier) <qKChP-8lQ-3@gated-at.bofh.it> <qKDnz-AY-1@gated-at.bofh.it> <qKDnA-AY-5@gated-at.bofh.it> <qKH7Q-3lo-1@gated-at.bofh.it> <qKH7Q-3lo-7@gated-at.bofh.it>
Organization	Samsung

Show all headers | View raw

Em Mon, 28 Dec 2015 15:38:54 +0100
SF Markus Elfring <elfring@users.sourceforge.net> escreveu:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 28 Dec 2015 15:10:30 +0100
> 
> This issue was detected by using the Coccinelle software.
> 
> Move the jump label directly before the desired log statement
> so that the variable "ret" will not be checked once more
> after a function call.
> Use the identifier "report_failure" instead of "err".
> 
> Suggested-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/media/tuners/m88rs6000t.c | 154 +++++++++++++++++++-------------------
>  1 file changed, 78 insertions(+), 76 deletions(-)
> 
> diff --git a/drivers/media/tuners/m88rs6000t.c b/drivers/media/tuners/m88rs6000t.c
> index 504bfbc..7e59a9f 100644
> --- a/drivers/media/tuners/m88rs6000t.c
> +++ b/drivers/media/tuners/m88rs6000t.c
> @@ -44,7 +44,7 @@ static int m88rs6000t_set_demod_mclk(struct dvb_frontend *fe)
>  	/* select demod main mclk */
>  	ret = regmap_read(dev->regmap, 0x15, &utmp);
>  	if (ret)
> -		goto err;
> +		goto report_failure;

Why to be so verbose? Calling it as "err" is enough, and it means less
code to type if we need to add another goto.

Regards,
Mauro

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] [media] m88rs6000t: Better exception handling in  five functions Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2016-01-25 18:10 +0100
  Re: [PATCH 1/2] [media] m88rs6000t: Better exception handling in five  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-25 19:30 +0100

csiph-web