Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1316955

Re: [PATCH] irqchip: s3c24xx: mark init_eint as __maybe_unused

Show all headers | View raw

On 25/01/16 15:58, Arnd Bergmann wrote:
> The init_eint array in the s3c24xx irqchip driver is used by
> every individual chip variant, but Kconfig allows building
> the driver when they are all disabled, and that leads to
> a harmless compile-time warning:
> 
> drivers/irqchip/irq-s3c24xx.c:608:28: error: 'init_eint' defined but not used [-Werror=unused-variable]
> 
> This marks the array as __maybe_unused to avoid the warning.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/irqchip/irq-s3c24xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-s3c24xx.c b/drivers/irqchip/irq-s3c24xx.c
> index c71914e8f596..5dc5a760c723 100644
> --- a/drivers/irqchip/irq-s3c24xx.c
> +++ b/drivers/irqchip/irq-s3c24xx.c
> @@ -605,7 +605,7 @@ err:
>  	return ERR_PTR(ret);
>  }
>  
> -static struct s3c_irq_data init_eint[32] = {
> +static struct s3c_irq_data __maybe_unused init_eint[32] = {
>  	{ .type = S3C_IRQTYPE_NONE, }, /* reserved */
>  	{ .type = S3C_IRQTYPE_NONE, }, /* reserved */
>  	{ .type = S3C_IRQTYPE_NONE, }, /* reserved */
> 

Acked-by: Marc Zyngier <marc.zyngier@arm.com>

	M.
-- 
Jazz is not dead. It just smells funny...

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] irqchip: s3c24xx: mark init_eint as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2016-01-25 17:00 +0100
  Re: [PATCH] irqchip: s3c24xx: mark init_eint as __maybe_unused Marc Zyngier <marc.zyngier@arm.com> - 2016-01-25 17:20 +0100
  [tip:irq/urgent] irqchip/s3c24xx:   Mark init_eint as __maybe_unused tip-bot for Arnd Bergmann <tipbot@zytor.com> - 2016-01-26 16:10 +0100

csiph-web