Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1316953

Re: [PATCH] watchdog: imgdpc: select WATCHDOG_CORE

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Jan 25, 2016 at 05:06:27PM +0100, Arnd Bergmann wrote:
> The imgpdc_wdt driver can be built on all architectures with
> CONFIG_COMPILE_TEST, but fails if no other watchdog driver is
> enabled:
> 
> drivers/watchdog/built-in.o: In function `pdc_wdt_remove':
> imgpdc_wdt.c:(.text+0x74): undefined reference to `watchdog_unregister_device'
> 
> This adds the normal 'select WATCHDOG_CORE' that is needed to
> ensure the driver always builds cleanly.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: James Hogan <james.hogan@imgtec.com>

Cheers
James

> ---
>  drivers/watchdog/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 4f0e7be0da34..0dc61f1a552e 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1383,6 +1383,7 @@ config IMGPDC_WDT
>  	tristate "Imagination Technologies PDC Watchdog Timer"
>  	depends on HAS_IOMEM
>  	depends on METAG || MIPS || COMPILE_TEST
> +	select WATCHDOG_CORE
>  	help
>  	  Driver for Imagination Technologies PowerDown Controller
>  	  Watchdog Timer.
> -- 
> 2.7.0
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] watchdog: imgdpc: select WATCHDOG_CORE Arnd Bergmann <arnd@arndb.de> - 2016-01-25 17:10 +0100
  Re: [PATCH] watchdog: imgdpc: select WATCHDOG_CORE James Hogan <james.hogan@imgtec.com> - 2016-01-25 17:20 +0100
  Re: [PATCH] watchdog: imgdpc: select WATCHDOG_CORE Guenter Roeck <linux@roeck-us.net> - 2016-01-25 17:50 +0100

csiph-web