Re: [PATCH v2] of: drop symbols declared by _OF_DECLARE() from modules

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] of: drop symbols declared by _OF_DECLARE() from modules
Date	2016-01-25 16:00 +0100
Message-ID	<qUQMx-5vw-1@gated-at.bofh.it> (permalink)
References	<qTqra-7RN-47@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jan 21, 2016 at 10:33 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> The users of this macro (OF_EARLYCON_DECLARE, CLK_OF_DECLARE,
> IRQCHIP_DECLARE, etc.) are only parsed in the early boot stage.
> Such symbols contained in modules are never used.
>
> This commit fixes the link error introduced by commit b8d20e06eaad
> ("serial: 8250_uniphier: add earlycon support"); the combination
> of CONFIG_SERIAL_8250_UNIPHIER=m and CONFIG_SERIAL_8250_CONSOLE=y
> fails to link:
>
> ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined!
>
> Fixes: b8d20e06eaad ("serial: 8250_uniphier: add earlycon support")
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> ---
>
> Changes in v2:
>   - Describe the bug fixed by this commit
>
>  include/linux/of.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] of: drop symbols declared by _OF_DECLARE() from modules Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-01-21 17:40 +0100
  Re: [PATCH v2] of: drop symbols declared by _OF_DECLARE() from modules Rob Herring <robh@kernel.org> - 2016-01-25 16:00 +0100

csiph-web