Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1316701
| From | Aleksey Makarov <aleksey.makarov@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/3] printk: make preferred_console local static bool |
| Date | 2016-01-25 14:30 +0100 |
| Message-ID | <qUPns-4s7-5@gated-at.bofh.it> (permalink) |
| References | <qUNOG-3ga-17@gated-at.bofh.it> <qUNOH-3ga-43@gated-at.bofh.it> <qUOKK-3WU-1@gated-at.bofh.it> <qUOUr-40h-35@gated-at.bofh.it> <qUPns-4s7-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 25.01.2016 19:23, Joe Perches wrote: > On Mon, 2016-01-25 at 18:51 +0600, Aleksey Makarov wrote: >> >> On 25.01.2016 18:45, Joe Perches wrote: >>> On Mon, 2016-01-25 at 17:45 +0600, Aleksey Makarov wrote: >>>> The variable preferred_console is used only inside register_console() >>>> and it's semantics is boolean. Make it clear. >>> >>> This loses the index of the preferred console. >>> I'm not sure this is better. >> >> That index is not used anywhere. I believe the patch makes things clear. > > Well, with this change the name and its use > is a bit misleading. Maybe changing it to > something like use_selected_console is better. Thank you. I will fix this in the next version.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] ACPI: parse the SPCR table Aleksey Makarov <aleksey.makarov@linaro.org> - 2016-01-25 12:50 +0100
[PATCH 1/3] printk: make preferred_console local static bool Aleksey Makarov <aleksey.makarov@linaro.org> - 2016-01-25 12:50 +0100
Re: [PATCH 1/3] printk: make preferred_console local static bool Joe Perches <joe@perches.com> - 2016-01-25 13:50 +0100
Re: [PATCH 1/3] printk: make preferred_console local static bool Aleksey Makarov <aleksey.makarov@linaro.org> - 2016-01-25 14:00 +0100
Re: [PATCH 1/3] printk: make preferred_console local static bool Aleksey Makarov <aleksey.makarov@linaro.org> - 2016-01-25 14:30 +0100
Re: [PATCH 1/3] printk: make preferred_console local static bool Peter Hurley <peter@hurleysoftware.com> - 2016-01-25 17:20 +0100
Re: [PATCH 1/3] printk: make preferred_console local static bool Joe Perches <joe@perches.com> - 2016-01-25 14:30 +0100
Re: [PATCH 1/3] printk: make preferred_console local static bool Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-25 15:30 +0100
Re: [PATCH 1/3] printk: make preferred_console local static bool Aleksey Makarov <aleksey.makarov@linaro.org> - 2016-01-25 16:00 +0100
[PATCH 3/3] serial: pl011: add acpi_match for amba-pl011.c Aleksey Makarov <aleksey.makarov@linaro.org> - 2016-01-25 12:50 +0100
Re: [PATCH 3/3] serial: pl011: add acpi_match for amba-pl011.c Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-25 15:30 +0100
Re: [PATCH 3/3] serial: pl011: add acpi_match for amba-pl011.c Aleksey Makarov <aleksey.makarov@linaro.org> - 2016-01-25 16:10 +0100
Re: [PATCH 3/3] serial: pl011: add acpi_match for amba-pl011.c Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-25 15:30 +0100
Re: [PATCH 0/3] ACPI: parse the SPCR table Peter Hurley <peter@hurleysoftware.com> - 2016-01-25 17:20 +0100
Re: [PATCH 0/3] ACPI: parse the SPCR table Aleksey Makarov <aleksey.makarov@linaro.org> - 2016-01-27 13:30 +0100
Re: [PATCH 0/3] ACPI: parse the SPCR table One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-01-27 14:50 +0100
csiph-web