Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1316680

Re: [tip:perf/urgent] perf: Fix perf_event_exit_task() race

Show all headers | View raw

---

Subject: perf: Fix orphan hole
From: Peter Zijlstra <peterz@infradead.org>
Date: Fri Jan 22 22:13:41 CET 2016

We should set event->owner before we install the event, otherwise
there is a hole where the target task can fork() and we'll not inherit
the event because it thinks the event is orphaned.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
 kernel/events/core.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -8489,6 +8489,8 @@ SYSCALL_DEFINE5(perf_event_open,
 	perf_event__header_size(event);
 	perf_event__id_header_size(event);
 
+	event->owner = current;
+
 	perf_install_in_context(ctx, event, event->cpu);
 	perf_unpin_context(ctx);
 
@@ -8498,8 +8500,6 @@ SYSCALL_DEFINE5(perf_event_open,
 
 	put_online_cpus();
 
-	event->owner = current;
-
 	mutex_lock(&current->perf_event_mutex);
 	list_add_tail(&event->owner_entry, &current->perf_event_list);
 	mutex_unlock(&current->perf_event_mutex);

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [tip:perf/urgent] perf: Fix perf_event_exit_task() race Peter Zijlstra <peterz@infradead.org> - 2016-01-25 14:10 +0100

csiph-web