Re: [RESEND v2 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7

From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [RESEND v2 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7
Date	2016-01-25 10:20 +0100
Message-ID	<qULtx-1Kq-11@gated-at.bofh.it> (permalink)
References	<qUDFF-4pc-5@gated-at.bofh.it> <qUDFF-4pc-9@gated-at.bofh.it> <qULjQ-1FX-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 25.01.2016 17:59, Arnd Bergmann wrote:
> On Monday 25 January 2016 09:50:20 Krzysztof Kozlowski wrote:
>>
>> +# ARM64 SoCs (e.g. Exynos5433, Exynos7):
>> +config EXYNOS_ARM64_COMMON_CLK
>> +       def_bool ARCH_EXYNOS
>> +       depends on ARM64 || COMPILE_TEST
>> +       select COMMON_CLK_SAMSUNG
>>
> 
> So you always enable it on ARM64 when ARCH_EXYNOS is enabled, but
> enable it silently on ARM32 when COMPILE_TEST is set?

Hmm... indeed it would better to make it toggle-able when COMPILE_TEST.

> That sounds wrong. How about
> 
> config EXYNOS_ARM64_COMMON_CLK
> 	bool "EXYNOS 64-bit clock support" if COMPILE_TEST
> 	default ARM64 && ARCH_EXYNOS
> 	depends on (ARM64 && ARCH_EXYNOS) || COMPILE_TEST
> 	select COMMON_CLK_SAMSUNG

Although this looks more complicated but it does the trick. Thanks for
the hint. Only one (not related directly to this change) issue - with
COMPILE_TEST the "EXYNOS 64-bit clock support" option goes above the
common clock framework (up to drivers section) because it is not part of
the Clocks menu. I'll fix it in v3.

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RESEND v2 0/2] arm64: EXYNOS: Consolidate Exynos7 symbol Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-25 02:00 +0100
  [RESEND v2 2/2] arm64: EXYNOS: Consolidate ARCH_EXYNOS7 symbol into  ARCH_EXYNOS Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-25 02:00 +0100
  [RESEND v2 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-25 02:00 +0100
    Re: [RESEND v2 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 Arnd Bergmann <arnd@arndb.de> - 2016-01-25 10:10 +0100
      Re: [RESEND v2 1/2] clk: samsung: Don't build ARMv8 clock drivers on  ARMv7 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-25 10:20 +0100

csiph-web