Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1316242

Re: [PATCH v3 1/4] extcon: arizona: Remove enable/disable of 32k clock

Show all headers | View raw

On 2016년 01월 08일 20:29, Charles Keepax wrote:
> The 32k clock is unconditionally enabled by the MFD core so there is no
> need to control it from the extcon device, so this patch removes the
> control of the 32k clock.
> 
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> 
> No changes since v2.
> 
> Thanks,
> Charles
> 
>  drivers/extcon/extcon-arizona.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index e4890dd..52d041f 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -1571,7 +1571,6 @@ static int arizona_extcon_probe(struct platform_device *pdev)
>  		goto err_micdet;
>  	}
>  
> -	arizona_clk32k_enable(arizona);
>  	regmap_update_bits(arizona->regmap, ARIZONA_JACK_DETECT_DEBOUNCE,
>  			   ARIZONA_JD1_DB, ARIZONA_JD1_DB);
>  	regmap_update_bits(arizona->regmap, ARIZONA_JACK_DETECT_ANALOGUE,
> @@ -1642,7 +1641,6 @@ static int arizona_extcon_remove(struct platform_device *pdev)
>  	cancel_delayed_work_sync(&info->hpdet_work);
>  	regmap_update_bits(arizona->regmap, ARIZONA_JACK_DETECT_ANALOGUE,
>  			   ARIZONA_JD1_ENA, 0);
> -	arizona_clk32k_disable(arizona);
>  
>  	return 0;
>  }
> 

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

If I apply only this patch on extcon tree,
the kernel build error will happen on other tree.
I think that this patch will go on clk tree and
then send pull request of immutable branch.

Thanks,
Chanwoo Choi

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v3 1/4] extcon: arizona: Remove enable/disable of 32k clock Chanwoo Choi <cw00.choi@samsung.com> - 2016-01-25 07:30 +0100

csiph-web