Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1316244

Re: [kernel] powerpc: Make vmalloc_to_phys() public

Show all headers | View raw

On 01/25/2016 11:16 AM, Michael Ellerman wrote:
> On Thu, 2016-21-01 at 07:35:08 UTC, Alexey Kardashevskiy wrote:
>> > This makes vmalloc_to_phys() public as there will be another user
>> > (in-kernel VFIO acceleration) for it soon.
>> > 
>> > As a part of future little optimization, this changes the helper to call
>> > vmalloc_to_pfn() instead of vmalloc_to_page() as the size of the
>> > struct page may not be power-of-two aligned which will make gcc use
>> > multiply instructions instead of shifts.
> You should also mention why you need to export it, presumably because whatever
> new user you have in mind can be built as a module.

Unless the change specifically mentions about the use case, there
are a tons of static helper functions which can be exported to public
for module usage. Ideally this change should be part of the series
which actually needs the helper function to be available in public
not a stand alone one.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH kernel] powerpc: Make vmalloc_to_phys() public Alexey Kardashevskiy <aik@ozlabs.ru> - 2016-01-21 08:40 +0100
  Re: [kernel] powerpc: Make vmalloc_to_phys() public Michael Ellerman <mpe@ellerman.id.au> - 2016-01-25 06:50 +0100
    Re: [kernel] powerpc: Make vmalloc_to_phys() public Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2016-01-25 07:30 +0100
    Re: [kernel] powerpc: Make vmalloc_to_phys() public Paul Mackerras <paulus@ozlabs.org> - 2016-01-25 11:10 +0100
      Re: [kernel] powerpc: Make vmalloc_to_phys() public Alexey Kardashevskiy <aik@ozlabs.ru> - 2016-01-27 04:30 +0100

csiph-web