Re: [PATCH] mmc: dw_mmc: fix err handle of dw_mci_probe

From	Jaehoon Chung <jh80.chung@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mmc: dw_mmc: fix err handle of dw_mci_probe
Date	2016-01-25 06:00 +0100
Message-ID	<qUHpU-754-5@gated-at.bofh.it> (permalink)
References	<qTEDM-Sz-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi, Shawn.

On 01/22/2016 04:43 PM, Shawn Lin wrote:
> This patch add correct err handle if dw_mci_ctrl_reset
> failed while probing.

Thanks! I will applied this.

Best Regards,
Jaehoon Chung

> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
> 
>  drivers/mmc/host/dw_mmc.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 065a8f5..ec19984 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -3046,8 +3046,10 @@ int dw_mci_probe(struct dw_mci *host)
>  	}
>  
>  	/* Reset all blocks */
> -	if (!dw_mci_ctrl_reset(host, SDMMC_CTRL_ALL_RESET_FLAGS))
> -		return -ENODEV;
> +	if (!dw_mci_ctrl_reset(host, SDMMC_CTRL_ALL_RESET_FLAGS)) {
> +		ret = -ENODEV;
> +		goto err_clk_ciu;
> +	}
>  
>  	host->dma_ops = host->pdata->dma_ops;
>  	dw_mci_init_dma(host);
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mmc: dw_mmc: fix err handle of dw_mci_probe Shawn Lin <shawn.lin@rock-chips.com> - 2016-01-22 08:50 +0100
  Re: [PATCH] mmc: dw_mmc: fix err handle of dw_mci_probe Jaehoon Chung <jh80.chung@samsung.com> - 2016-01-25 06:00 +0100

csiph-web