Re: [PATCH] [media] media: Kconfig: add dependency of HAS_DMA

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] [media] media: Kconfig: add dependency of HAS_DMA
Date	Sat, 23 Jan 2016 15:00:02 +0100
Message-ID	<qU6To-3st-1@gated-at.bofh.it> (permalink)
References	<qLoZd-79S-43@gated-at.bofh.it>
X-Original-To	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=cyXJEmSBffY2NDDt94Qk2gNcw1uDG0RtErCh/ZSBNM0=; b=tyKGRKFa/m//CG3PghazM28B6p5JHVi/lmYYzMg3ad6gjKDrZKKJEzVV3TMwaxjXjT Hx610na0ALjEUfI8VeudXAww/jSXulzvtF9z4Hb51mp4pRhs5djjlivv6uPq6VzUor+V xOi8DzTPZGKlaC6GH8ymzAZpOBjQAn6eSh0qjbRm+zNaiCvsCrbA3quU3WvXOzWdchBs il3yTQTx9Q3zQyvl2Z8ifQ5JjC1IhhJZ7e2wsaVpejtvlM0h8iS/ZsYYCQQllpQN2uXb 7cyDJx0JOUDNpWbe7pLNR7tadmMuhVyGDyBXIrh0fvIjuY9nTZ28pXXN3imB08wPRLVl y3Cw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=cyXJEmSBffY2NDDt94Qk2gNcw1uDG0RtErCh/ZSBNM0=; b=a6SspQMXF8VpZa+JkLTy/atw4UEbMpNzntFK4sW3wCtBo28sz+LDZNKDOCOOp0gyXi GPdEIOy+8ij+Y+Lo+RtDC0K5pjKl4mZg4EJJDfLhGoJdcXKJA/5yd20eifVYXClBQzgs K84XYBGN49TpZCHfd+GVHcgghWBVROPZvHeRQG91GA9e7l/6sY3Uf0mLOyMkgIwuE4B4 E1AOtDLk+uQg/k8ScImA9+8H4I132ZN7rxGjCAsPW1HWm7blzFouHFXVOMWBz1FtNkvn NqwAwkrUzmSd6vHeiyAZvbUp83T1zOBu7rd65Bt+5t9TyrBGfC+YzfoSrhlBeA96/vFb p7eg==
X-Gm-Message-State	AG10YOTCfpk+3zALNfM6U5pE/HzbW63d653TTZg/FxWYS0/BYMC/288ns+A3LquOrF0lDFhhj7DurPWTswbYUw==
MIME-Version	1.0
X-Received	by 10.107.148.75 with SMTP id w72mr10068861iod.115.1453557320436; Sat, 23 Jan 2016 05:55:20 -0800 (PST)
X-Google-Sender-Auth	y_shE1VeCT2zXXh-JwraK84bKGU
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	25
Organization	linux.* mail to news gateway
X-Original-Cc	Mauro Carvalho Chehab <mchehab@osg.samsung.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Linux Media Mailing List <linux-media@vger.kernel.org>, Andrew Morton <akpm@linux-foundation.org>
X-Original-Date	Sat, 23 Jan 2016 14:55:20 +0100
X-Original-Message-ID	<CAMuHMdVYy+O6oAHAH-uQoEsrdCJD0ex9cp79ry=FbevDAQbH+A@mail.gmail.com>
X-Original-References	<1451481963-18853-1-git-send-email-sudipm.mukherjee@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1315599

Show key headers only | View raw

On Wed, Dec 30, 2015 at 2:26 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> The build of m32r allmodconfig fails with the error:
> drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2:
>         error: implicit declaration of function 'dma_get_cache_alignment'
>
> The build of videobuf2-dma-contig.c depends on HAS_DMA and it is
> correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also
> selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile
> videobuf2-dma-contig.c even though HAS_DMA is not defined.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] [media] media: Kconfig: add dependency of HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2016-01-23 15:00 +0100

csiph-web