Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1315569
| From | Robert Richter <robert.richter@caviumnetworks.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 04/12] acpi, numa: introduce ACPI_HAS_NUMA_ARCH_FIXUP |
| Date | 2016-01-23 11:30 +0100 |
| Message-ID | <qU3C9-1go-17@gated-at.bofh.it> (permalink) |
| References | <qU2Zr-K2-5@gated-at.bofh.it> <qU2Zs-K2-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 23.01.16 17:39:19, Hanjun Guo wrote: > From: Hanjun Guo <hanjun.guo@linaro.org> > > acpi_numa_arch_fixup() is only used for IA64, x86 introduce a dummy > function for it, when we came to a new architecture (such as ARM64), > we need to introduce another dummy one to make the code compile. > > That's pretty boring so introduce ACPI_HAS_NUMA_ARCH_FIXUP and > select it for IA64, introduce a stub function for acpi_numa_arch_fixup() > then it's pretty clean for x86 and ARM64. > > Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org> > --- > arch/ia64/Kconfig | 1 + I see an implementation of acpi_numa_arch_fixup() only for ia64. Why not move it to arch/ia64 then and call it from setup_arch() in arch/ia64/kernel/setup.c after acpi_numa_init()? It looks like we don't need a generic solution for this. This avoids any kconfig handling for this at all. -Robert
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 04/12] acpi, numa: introduce ACPI_HAS_NUMA_ARCH_FIXUP Hanjun Guo <guohanjun@huawei.com> - 2016-01-23 10:50 +0100
Re: [PATCH v3 04/12] acpi, numa: introduce ACPI_HAS_NUMA_ARCH_FIXUP Robert Richter <robert.richter@caviumnetworks.com> - 2016-01-23 11:30 +0100
Re: [PATCH v3 04/12] acpi, numa: introduce ACPI_HAS_NUMA_ARCH_FIXUP Hanjun Guo <hanjun.guo@linaro.org> - 2016-01-24 06:00 +0100
csiph-web