Re: [PATCH v4 1/4] Input: cyttsp - use devres managed resource allocations

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/4] Input: cyttsp - use devres managed resource allocations
Date	2016-01-21 22:40 +0100
Message-ID	<qTv7t-2E4-39@gated-at.bofh.it> (permalink)
References	<qTt5E-1hZ-7@gated-at.bofh.it> <qTt5F-1hZ-27@gated-at.bofh.it> <qTt5F-1hZ-41@gated-at.bofh.it> <qTu1I-1V0-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jan 21, 2016 at 09:22:05PM +0100, Oreste Salerno wrote:
> On Thu, Jan 21, 2016 at 11:29:24AM -0800, Dmitry Torokhov wrote:
> > Hi Oreste,
> > 
> > On Thu, Jan 21, 2016 at 08:21:13PM +0100, Oreste Salerno wrote:
> > > Use devm_() functions for allocating memory, input device and IRQ.
> > > 
> > 
> > ...
> > 
> > > @@ -625,11 +620,8 @@ EXPORT_SYMBOL_GPL(cyttsp_probe);
> > >  
> > >  void cyttsp_remove(struct cyttsp *ts)
> > >  {
> > > -	free_irq(ts->irq, ts);
> > > -	input_unregister_device(ts->input);
> > >  	if (ts->pdata->exit)
> > >  		ts->pdata->exit();
> > > -	kfree(ts);
> > 
> > This is not quite correct as it changes the operations order... Given
> > that it is going to be removed in the next patch I guess it is OK, but
> > ideally you can add a custom devm action to shut off the chip.
> >
> 
> You mean a devm action to call pdata->exit() ? OK, I could do that.

Yes.

Thanks.

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 1/4] Input: cyttsp - use devres managed resource allocations Oreste Salerno <oreste.salerno@tomtom.com> - 2016-01-21 20:30 +0100
  Re: [PATCH v4 1/4] Input: cyttsp - use devres managed resource  allocations Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-01-21 20:30 +0100
    Re: [PATCH v4 1/4] Input: cyttsp - use devres managed resource  allocations Oreste Salerno <oreste.salerno@tomtom.com> - 2016-01-21 21:30 +0100
      Re: [PATCH v4 1/4] Input: cyttsp - use devres managed resource  allocations Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-01-21 22:40 +0100

csiph-web