Re: [PATCH] staging: iio: replace clk_get() with devm_clk_get()

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: iio: replace clk_get() with devm_clk_get()
Date	2016-01-21 20:50 +0100
Message-ID	<qTtp0-1qg-3@gated-at.bofh.it> (permalink)
References	<qTjIZ-3ho-1@gated-at.bofh.it> <qTt5F-1hZ-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jan 21, 2016 at 11:21:53AM -0800, Matt Ranostay wrote:
> > @@ -356,8 +356,6 @@ static int spear_adc_probe(struct platform_device *pdev)
> >
> >  errout3:
> >         clk_disable_unprepare(st->clk);
> 
> Shouldn't errout3 now be errout2.. having a gap would seem odd.
> 
> > -errout2:
> > -       clk_put(st->clk);
> >  errout1:
> >         iounmap(st->adc_base_spear6xx);

GW-BASIC style numbered gotos are nonsense.  Label names should be name
after what the label does.

err_unprepare:
err_put:
err_iounmap:

But that's something for a different patch, not related to this patch.

regards,
dan carpenter

Thread

[PATCH] staging: iio: replace clk_get() with devm_clk_get() "Gujulan Elango, Hari Prasath (H.)" <hgujulan@visteon.com> - 2016-01-21 10:30 +0100
  Re: [PATCH] staging: iio: replace clk_get() with devm_clk_get() Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-21 10:50 +0100
    Re: [PATCH] staging: iio: replace clk_get() with devm_clk_get() "Gujulan Elango, Hari Prasath (H.)" <hgujulan@visteon.com> - 2016-01-21 11:00 +0100
  Re: [PATCH] staging: iio: replace clk_get() with devm_clk_get() Matt Ranostay <mranostay@gmail.com> - 2016-01-21 20:30 +0100
    Re: [PATCH] staging: iio: replace clk_get() with devm_clk_get() Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-21 20:50 +0100
    Re: [PATCH] staging: iio: replace clk_get() with devm_clk_get() "Gujulan Elango, Hari Prasath (H.)" <hgujulan@visteon.com> - 2016-01-22 10:10 +0100

csiph-web