Re: [PATCH] x86/efi: Setup separate EFI page tables in kexec paths

From	Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86/efi: Setup separate EFI page tables in kexec paths
Date	2016-01-21 20:40 +0100
Message-ID	<qTtfj-1mO-1@gated-at.bofh.it> (permalink)
References	<qTofE-6n5-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Matt Fleming <matt@codeblueprint.co.uk> [2016-01-21 14:11:59]:

> The switch to using a new dedicated page table for EFI runtime calls
> in commit commit 67a9108ed431 ("x86/efi: Build our own page table
> structures") failed to take into account changes required for the
> kexec code paths, which are unfortunately duplicated in the EFI code.
> 
> Call the allocation and setup functions in kexec_enter_virtual_mode()
> just like we do for __efi_enter_virtual_mode() to avoid hitting
> NULL-pointer dereferences when making EFI runtime calls.
> 
> At the very least, the call to efi_setup_page_tables() should have
> existed for kexec before commit 67a9108ed431. Things just magically
> worked because we were actually using the kernel's page tables that
> contained the required mappings.
> 
> Reported-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> Cc: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
> Cc: Dave Young <dyoung@redhat.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Borislav Petkov <bp@alien8.de>
> Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk>

Applied this patch on top of tip/x86/efi and was able to build and boot
the kernel.

-- 
Thanks and Regards
Srikar Dronamraju

Thread

[PATCH] x86/efi: Setup separate EFI page tables in kexec paths Matt Fleming <matt@codeblueprint.co.uk> - 2016-01-21 15:20 +0100
  Re: [PATCH] x86/efi: Setup separate EFI page tables in kexec paths Srikar Dronamraju <srikar@linux.vnet.ibm.com> - 2016-01-21 20:40 +0100
    Re: [PATCH] x86/efi: Setup separate EFI page tables in kexec paths Matt Fleming <matt@codeblueprint.co.uk> - 2016-01-21 22:00 +0100
      Re: [PATCH] x86/efi: Setup separate EFI page tables in kexec paths Matt Fleming <matt@codeblueprint.co.uk> - 2016-01-25 10:50 +0100
  [tip:efi/core] x86/efi:   Setup separate EFI page tables in kexec paths tip-bot for Matt Fleming <tipbot@zytor.com> - 2016-01-22 14:00 +0100

csiph-web