Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1314399

Re: [PATCH] spi: qup: provide proper bus numbers

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Jan 21, 2016 at 06:33:47PM +0000, Srinivas Kandagatla wrote:

> This driver reuses pdev->id for spi bus numbers resulting in random
> or very large bus numbering when used with device trees. pdev->id
> is not the correct choice when using device trees. So add code to

What makes you say this, why is pdev->id not "correct"?  It is worrying
if anything cares what number we pick.

> get bus numbers via device tree aliases and if it fails then generate
> a unique bus number.

The other question is even if this is a good idea why is it something
that should be open coded in individual drivers, if we want to change
the policy we should be consistent between drivers.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] spi: qup: provide proper bus numbers Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-01-21 19:40 +0100
  Re: [PATCH] spi: qup: provide proper bus numbers Mark Brown <broonie@kernel.org> - 2016-01-21 19:40 +0100
    Re: [PATCH] spi: qup: provide proper bus numbers Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-01-21 19:50 +0100
      Re: [PATCH] spi: qup: provide proper bus numbers Mark Brown <broonie@kernel.org> - 2016-01-21 20:10 +0100
        Re: [PATCH] spi: qup: provide proper bus numbers Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-01-21 20:30 +0100
          Re: [PATCH] spi: qup: provide proper bus numbers Mark Brown <broonie@kernel.org> - 2016-01-21 21:20 +0100

csiph-web