Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1314242

Re: [PATCH V3 00/11] Add T210 support in Tegra soctherm

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Jan 18, 2016 at 06:02:25PM +0800, Wei Ni wrote:
> This patchset adds following functions for tegra_soctherm driver:
> 1. add T210 support.
> 2. export debugfs to show some registers.
> 3. add thermtrip funciton.
> 4. add suspend/resume function.
> 
> The V1 serial is in:
> http://www.spinics.net/lists/linux-tegra/msg24808.html
> The V2 serial is in:
> http://www.spinics.net/lists/linux-tegra/msg24901.html
> 
> Main changes from V2:
> 1. Fix build error in patch [1/11].
> 2. Use of_get_child_by_name instead of of_find_node_by_name in patch [8/11].
> 3. Use debugfs_remove_recursive to remove debugfs in patch [6/11].
> 
> Main changes from V1:
> 1. Use the new type to handl different Tegra chips in one driver,
> which suggested by Thierry.
> 2. Changes per Thieery's other comments.
> 
> Wei Ni (11):
>   thermal: tegra: move tegra thermal files into tegra directory
>   thermal: tegra: combine sensor group-related data
>   thermal: tegra: get rid of PDIV/HOTSPOT hack
>   thermal: tegra: split tegra_soctherm driver
>   thermal: tegra: add T210-specific SOC_THERM driver
>   thermal: tegra: add a debugfs to show registers
>   of: Add bindings of hw-trips for soctherm
>   thermal: tegra: add thermtrip function
>   thermal: tegra: add PM support
>   arm64: tegra: add soctherm node for Tegra210
>   ARM: tegra: set hw trips for Tegra124

Hi Wei,

This series looks mostly good to me. I've commented on a couple of minor
things as replies to the individual patches.

On a higher level, what's the test procedure that we can use to validate
that this code works?

Thierry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V3 00/11] Add T210 support in Tegra soctherm Wei Ni <wni@nvidia.com> - 2016-01-18 11:10 +0100
  [PATCH V3 02/11] thermal: tegra: combine sensor group-related data Wei Ni <wni@nvidia.com> - 2016-01-18 11:10 +0100
  [PATCH V3 03/11] thermal: tegra: get rid of PDIV/HOTSPOT hack Wei Ni <wni@nvidia.com> - 2016-01-18 11:10 +0100
  [PATCH V3 01/11] thermal: tegra: move tegra thermal files into tegra directory Wei Ni <wni@nvidia.com> - 2016-01-18 11:10 +0100
  Re: [PATCH V3 04/11] thermal: tegra: split tegra_soctherm driver Thierry Reding <thierry.reding@gmail.com> - 2016-01-21 15:50 +0100
    Re: [PATCH V3 04/11] thermal: tegra: split tegra_soctherm driver Wei Ni <wni@nvidia.com> - 2016-01-22 10:00 +0100
  Re: [PATCH V3 00/11] Add T210 support in Tegra soctherm Thierry Reding <thierry.reding@gmail.com> - 2016-01-21 16:00 +0100
    Re: [PATCH V3 00/11] Add T210 support in Tegra soctherm Wei Ni <wni@nvidia.com> - 2016-01-22 08:30 +0100

csiph-web