Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1314234
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Richard Fitzgerald <rf@opensource.wolfsonmicro.com> |
| Newsgroups | linux.kernel |
| Subject | [PATCH] ASoC: wm5110: Unregister compressed platform when driver is removed |
| Date | Thu, 21 Jan 2016 15:50:02 +0100 |
| Message-ID | <qToIG-6z7-33@gated-at.bofh.it> (permalink) |
| X-Original-To | <broonie@kernel.org>, <lgirdwood@gmail.com> |
| Authentication-Results | ppops.net; spf=none smtp.mail=rf@opensource.wolfsonmicro.com |
| X-Mailer | git-send-email 1.9.1 |
| MIME-Version | 1.0 |
| Content-Type | text/plain |
| X-Proofpoint-Spam-Details | rule=notspam policy=default score=0 spamscore=0 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310008 definitions=main-1601210258 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 24 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | <patches@opensource.wolfsonmicro.com>, <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org> |
| X-Original-Date | Thu, 21 Jan 2016 14:41:12 +0000 |
| X-Original-Message-ID | <1453387272-3674-1-git-send-email-rf@opensource.wolfsonmicro.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1314234 |
Show key headers only | View raw
The driver was not unregistering the compressed platform in
wm5110_remove(). If the codec is built as a module, this would
lead to a NULL pointer deref if the module was unloaded and then
re-probed.
Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
---
sound/soc/codecs/wm5110.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/wm5110.c b/sound/soc/codecs/wm5110.c
index 6088d30..97c0f1e 100644
--- a/sound/soc/codecs/wm5110.c
+++ b/sound/soc/codecs/wm5110.c
@@ -2382,6 +2382,7 @@ error:
static int wm5110_remove(struct platform_device *pdev)
{
+ snd_soc_unregister_platform(&pdev->dev);
snd_soc_unregister_codec(&pdev->dev);
pm_runtime_disable(&pdev->dev);
--
1.9.1
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH] ASoC: wm5110: Unregister compressed platform when driver is removed Richard Fitzgerald <rf@opensource.wolfsonmicro.com> - 2016-01-21 15:50 +0100
csiph-web