Re: [PATCH 01/14] dell-laptop: extract SMBIOS-related code to a separate module

From	Michał Kępień <kernel@kempniu.pl>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/14] dell-laptop: extract SMBIOS-related code to a separate module
Date	2016-01-21 14:40 +0100
Message-ID	<qTnCV-5S1-3@gated-at.bofh.it> (permalink)
References	(2 earlier) <qRAXD-643-1@gated-at.bofh.it> <qSXfs-4qR-11@gated-at.bofh.it> <qTiWC-2IG-7@gated-at.bofh.it> <qTn9U-5Gc-7@gated-at.bofh.it> <qTnjz-5JB-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> Another idea:
> 
> What about passing struct calling_interface_buffer from caller allocated
> memory (either from stack or kernel alloc) to dell-smbios which will
> copy it into own buffer under 4GB and then pass it to dcdbas?
> 
> This will avoid to use that get/release function and there will be only
> one send_request.

Well, yes, these two functions could then be ripped out, but the callers
would have to do the error checking on their own.  Of course that's not
a bad thing per se, but it changes the currently used concept.

> But I will let decision for API to other people as I do not know what
> the best API to use here...

In order to avoid delaying this any further, I'll post a v2 soon and
hopefully it'll be good enough for your Acked-by.  If it turns out more
people have misgivings about it, I'll adjust the code.

-- 
Best regards,
Michał Kępień

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 01/14] dell-laptop: extract SMBIOS-related code to a  separate module Pali Rohár <pali.rohar@gmail.com> - 2016-01-16 16:30 +0100
  Re: [PATCH 01/14] dell-laptop: extract SMBIOS-related code to a  separate module Michał Kępień <kernel@kempniu.pl> - 2016-01-18 11:40 +0100
  Re: [PATCH 01/14] dell-laptop: extract SMBIOS-related code to a  separate module Michał Kępień <kernel@kempniu.pl> - 2016-01-20 10:30 +0100
    Re: [PATCH 01/14] dell-laptop: extract SMBIOS-related code to a  separate module Pali Rohár <pali.rohar@gmail.com> - 2016-01-21 09:40 +0100
      Re: [PATCH 01/14] dell-laptop: extract SMBIOS-related code to a  separate module Michał Kępień <kernel@kempniu.pl> - 2016-01-21 14:10 +0100
        Re: [PATCH 01/14] dell-laptop: extract SMBIOS-related code to a  separate module Pali Rohár <pali.rohar@gmail.com> - 2016-01-21 14:20 +0100
          Re: [PATCH 01/14] dell-laptop: extract SMBIOS-related code to a  separate module Michał Kępień <kernel@kempniu.pl> - 2016-01-21 14:40 +0100

csiph-web