Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1314186

Re: [PATCH v2 1/1] Support for CMedia CM6533 HID audio jack controls

From Jiri Kosina <jikos@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 1/1] Support for CMedia CM6533 HID audio jack controls
Date 2016-01-21 14:10 +0100
Message-ID <qTn9T-5Gc-1@gated-at.bofh.it> (permalink)
References <qLjwu-3BZ-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, 30 Dec 2015, Ben Chen wrote:

> The C-Media CM6533 is a USB audio chip featuring it's jack detection capability.The device originates an interrupt transfer via HID interface each time when a jack event occurs.
> The purpose of this patch is to handle hid raw events to keep the operating system informed of user interactions.
> 
> Signed-off-by: Ben Chen <ben_chen@bizlinktech.com>
> ---
> Changes in v2:
> - The return type of input_configured callback has been changed from void to be int.
> 
>  drivers/hid/Kconfig      |   6 ++
>  drivers/hid/Makefile     |   1 +
>  drivers/hid/hid-cm6533.c | 168 +++++++++++++++++++++++++++++++++++++++++++++++

We usually name the drivers according to the vendor name. IOW, I'd suggest 
you rename the driver to hid-cmedia.

Thanks,

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH v2 1/1] Support for CMedia CM6533 HID audio jack  controls Jiri Kosina <jikos@kernel.org> - 2016-01-21 14:10 +0100

csiph-web