Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1314184
| From | Gustavo Padovan <gustavo@padovan.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 10/11] staging/android: remove pointless sync_timeline_signal at destroy phase |
| Date | 2016-01-21 14:00 +0100 |
| Message-ID | <qTn0f-5nD-45@gated-at.bofh.it> (permalink) |
| References | <qTn0d-5nD-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk> All changes to timeline value come through the user via sync_timeline_signal() calls. When sync_timeline_destroy() is called no changes on timeline->value happens hence call sync_timeline_signal() with no increment is pointless. Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> --- drivers/staging/android/sync.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c index 9ec55ef..b9f167f 100644 --- a/drivers/staging/android/sync.c +++ b/drivers/staging/android/sync.c @@ -90,10 +90,6 @@ void sync_timeline_destroy(struct sync_timeline *obj) */ smp_wmb(); - /* - * signal any children that their parent is going away. - */ - sync_timeline_signal(obj); sync_timeline_put(obj); } EXPORT_SYMBOL(sync_timeline_destroy); -- 2.5.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/11] sync framework de-staging: part 1 - clean up Gustavo Padovan <gustavo@padovan.org> - 2016-01-21 14:00 +0100 [PATCH 10/11] staging/android: remove pointless sync_timeline_signal at destroy phase Gustavo Padovan <gustavo@padovan.org> - 2016-01-21 14:00 +0100 [PATCH 05/11] staging/android: move SW_SYNC_USER to a debugfs file Gustavo Padovan <gustavo@padovan.org> - 2016-01-21 14:00 +0100 Re: [PATCH 00/11] sync framework de-staging: part 1 - clean up Maarten Lankhorst <maarten.lankhorst@linux.intel.com> - 2016-01-25 12:30 +0100
csiph-web