Re: [PATCH] af_packet: Raw socket destruction warning fix

From	Maninder Singh <maninder1.s@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] af_packet: Raw socket destruction warning fix
Date	2016-01-21 12:50 +0100
Message-ID	<qTlUt-4G5-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Daniel,

>The other sock_put() in packet_release() to drop the final ref and call into
>sk_free(), which drops the 1 ref on the sk_wmem_alloc from init time. Since you
>got into __sk_free() via sock_wfree() destructor, your socket must have invoked
>packet_release() prior to this (perhaps kernel destroying the process).
>
>What kernel do you use?

Issue is coming for 3.10.58.

>> Driver calls dev_kfree_skb_any->dev_kfree_skb_irq
>> and it adds buffer in completion queue to free and raises softirq NET_TX_SOFTIRQ
>>
>> net_tx_action->__kfree_skb->skb_release_all->skb_release_head_state->sock_wfree->
>> __sk_free->packet_sock_destruct
>>
>> Also purging of receive queue has been taken care in other protocols.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] af_packet: Raw socket destruction warning fix Maninder Singh <maninder1.s@samsung.com> - 2016-01-21 12:50 +0100
  Re: [PATCH] af_packet: Raw socket destruction warning fix Daniel Borkmann <daniel@iogearbox.net> - 2016-01-26 01:20 +0100

csiph-web