Re: [PATCH v3] dt: bindings: add bindings for ipq4019 wifi block

Path	csiph.com!weretis.net!feeder4.news.weretis.net!storethat.news.telefonica.de!telefonica.de!news.panservice.it!bofh.it!news.nic.it!robomod
From	Kalle Valo <kvalo@qca.qualcomm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] dt: bindings: add bindings for ipq4019 wifi block
Date	Thu, 21 Jan 2016 12:50:01 +0100
Message-ID	<qTlUt-4G5-1@gated-at.bofh.it> (permalink)
References	<qQmN3-3ZY-5@gated-at.bofh.it> <qR2jf-7U0-1@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=simple/simple; d=qca.qualcomm.com; i=@qca.qualcomm.com; q=dns/txt; s=qcdkim; t=1453376775; x=1484912775; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=QaF1av5rYqQ4YunRMJzuu+b/GD+WeFqtsNq4eoiPvWk=; b=A3vQnfH0trFH1aCCmqEhNjRLCWe6CxkiXh8s3lV5CSuaRjs5NJgSF0c7 Cq8heryYfqRTK2bedwSE0clsFWISnS/rcsRmwvrlivA7FBWPoccv7JwI5 /yBPnVRO1AdVp/EBV3g5GYSWISQya+RfWF9eqGAlS/+3v+j9Q1xEGIUlK 0=;
X-Ironport-Av	E=Sophos;i="5.22,325,1449561600"; d="scan'208";a="107085055"
X-Ironport-Av	E=McAfee;i="5700,7163,8050"; a="1076702908"
User-Agent	Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)
MIME-Version	1.0
Content-Type	text/plain; charset="us-ascii"
X-Originating-IP	[10.80.80.8]
X-Clientproxiedby	NASANEXM01B.na.qualcomm.com (10.85.0.82) To eusanexr01a.eu.qualcomm.com (10.85.0.97)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Cc	Raja Mani <rmani@qti.qualcomm.com>, <devicetree@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>, <linux-wireless@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <ath10k@lists.infradead.org>, <agross@codeaurora.org>
X-Original-Date	Thu, 21 Jan 2016 13:46:02 +0200
X-Original-Message-ID	<87y4bjyx39.fsf@kamboji.qca.qualcomm.com>
X-Original-References	<1452664604-8014-1-git-send-email-rmani@qti.qualcomm.com> <20160115022021.GA27099@rob-hp-laptop>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1314127

Show key headers only | View raw

Rob Herring <robh@kernel.org> writes:

> On Wed, Jan 13, 2016 at 11:26:44AM +0530, Raja Mani wrote:
>> Add device tree binding documentation details for wifi block present
>> in Qualcomm IPQ4019 SoC into "qcom,ath10k.txt".
>> 
>> Right now, ath10k wireless driver has support for PCI based wlan devices.
>> There is a plan to extend ath10k driver to support wifi devices which are
>> connected over AHB as well (enumeration will happen via device tree node).
>> For AHB based devices (ie, ipq4019), all wifi properties are supplied via
>> device tree (including irq, reg addr, cal data,etc).
>> 
>> Signed-off-by: Raja Mani <rmani@qti.qualcomm.com>
>> ---
>> v3 changes:
>>   - Removed core-id - [Rob]
>>   - Documented which compatible string corresponds to pci devices
>>     and which corresponds to ahb devices. - [Rob]
>> 
>> v2 changes:
>>  - Improved "core-id" description - [Rob]
>>  - Removed "status" documentation - [Rob]
>>  - Added description which properties are applicable
>>    for ahb and which are applicable for pci devices - [Rob]
>>  - Improved commit msg to explain the context.
>>  - Renamed "qca,msi_addr" to "qcom,msi_addr" and
>>    "qca,msi_base" to "qcom,msi_base" to follow uniformity.
>> 
>>  .../bindings/net/wireless/qcom,ath10k.txt          | 89 ++++++++++++++++++++--
>>  1 file changed, 84 insertions(+), 5 deletions(-)
>
> A few typos, otherwise:
>
> Acked-by: Rob Herring <robh@kernel.org>

Rob, thank you for the review. I fixed the typos in ath.git pending
branch and will properly apply this in few days.

-- 
Kalle Valo

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v3] dt: bindings: add bindings for ipq4019 wifi block Kalle Valo <kvalo@qca.qualcomm.com> - 2016-01-21 12:50 +0100

csiph-web