Re: [PATCH 2/2] vhost: disentangle vring endianness stuff from the core code

From	Cornelia Huck <cornelia.huck@de.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] vhost: disentangle vring endianness stuff from the core code
Date	2016-01-21 11:00 +0100
Message-ID	<qTkc3-3tc-19@gated-at.bofh.it> (permalink)
References	<qQx5M-2Pq-9@gated-at.bofh.it> <qQx5O-2Pq-43@gated-at.bofh.it>
Organization	IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294

Show all headers | View raw

On Wed, 13 Jan 2016 18:09:47 +0100
Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:

> The way vring endianness is being handled currently obfuscates
> the code in vhost_init_used().
> 
> This patch tries to fix that by doing the following:
> - move the the code that adjusts endianness to a dedicated helper
> - export this helper so that backends explicitely call it
> 
> No behaviour change.
> 
> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> ---
>  drivers/vhost/net.c   |    3 +++
>  drivers/vhost/scsi.c  |    3 +++
>  drivers/vhost/test.c  |    2 ++
>  drivers/vhost/vhost.c |   16 +++++++++++-----
>  drivers/vhost/vhost.h |    1 +
>  5 files changed, 20 insertions(+), 5 deletions(-)

Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] vhost: disentangle vring endianness stuff from the  core code Cornelia Huck <cornelia.huck@de.ibm.com> - 2016-01-21 11:00 +0100

csiph-web