Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1314084

Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional

From Lothar Waßmann <LW@KARO-electronics.de>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional
Date 2016-01-21 11:30 +0100
Message-ID <qTkF5-3Th-43@gated-at.bofh.it> (permalink)
References <qT0dk-6mw-13@gated-at.bofh.it> <qT0dl-6mw-25@gated-at.bofh.it> <qT47h-Ma-27@gated-at.bofh.it> <qThxv-1Ov-11@gated-at.bofh.it> <qTkF4-3Th-21@gated-at.bofh.it>
Organization Ka-Ro electronics GmbH

Show all headers | View raw

Hi,

> On Thu, Jan 21, 2016 at 08:05:24AM +0100, Lothar Waßmann wrote:
> > > On Wed, Jan 20, 2016 at 01:29:51PM +0100, Lothar Waßmann wrote:
> 
> > > > This pin is used as IRQ pin for the LTC3589 PMIC on the Ka-Ro
> > > > electronics TX48 module. Make the IRQ optional in the driver and use a
> > > > polling routine instead if no IRQ is specified in DT.
> > > > Otherwise the driver will continuously generate interrupts and make
> > > > the system unusable.
> 
> > > How will the driver generate interrupts if there is no interrupt
> > > physically present in the system?
> 
> > It's using timer interrupts to poll the LTC3589 state.
> 
> I know that is what your patch does, my question is why you say in your
> commit log that "Otherwise the driver will continuously generate
> interrupts and make the system unusable".
>
Because the interrupt is level triggered and the polarity of the
EXTINT pin is inverted, the interrupt will be constantly active when
the IRQ pin of the LTC3589 is inactive.


Lothar Waßmann

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

PATCH [0/2] ARM: dts: am33xx: add support for Ka-Ro electronics TX48-7020 module Lothar Waßmann <LW@KARO-electronics.de> - 2016-01-20 13:40 +0100
  [PATCH 1/2] regulator: ltc3589: make IRQ optional Lothar Waßmann <LW@KARO-electronics.de> - 2016-01-20 13:40 +0100
    Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional Mark Brown <broonie@kernel.org> - 2016-01-20 17:50 +0100
      Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional Lothar Waßmann <LW@KARO-electronics.de> - 2016-01-21 08:10 +0100
        Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional Mark Brown <broonie@kernel.org> - 2016-01-21 11:30 +0100
          Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional Lothar Waßmann <LW@KARO-electronics.de> - 2016-01-21 11:30 +0100
            Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional Mark Brown <broonie@kernel.org> - 2016-01-21 12:20 +0100
              Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional Lothar Waßmann <LW@KARO-electronics.de> - 2016-01-21 12:40 +0100
                Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional Mark Brown <broonie@kernel.org> - 2016-01-21 17:30 +0100
                Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional Lothar Waßmann <LW@KARO-electronics.de> - 2016-01-22 06:50 +0100
                Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional Mark Brown <broonie@kernel.org> - 2016-01-22 17:30 +0100
                Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional Lothar Waßmann <LW@KARO-electronics.de> - 2016-01-25 13:40 +0100
                Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional Mark Brown <broonie@kernel.org> - 2016-01-25 13:50 +0100
                Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional Lothar Waßmann <LW@KARO-electronics.de> - 2016-01-25 14:00 +0100
                Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional Mark Brown <broonie@kernel.org> - 2016-01-25 15:00 +0100
    Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional Grygorii Strashko <grygorii.strashko@ti.com> - 2016-01-20 18:40 +0100

csiph-web