Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1313983
| From | Daniel Vetter <daniel@ffwll.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon |
| Date | 2016-01-21 09:00 +0100 |
| Message-ID | <qTijU-2ct-13@gated-at.bofh.it> (permalink) |
| References | (4 earlier) <qT7HQ-3eL-7@gated-at.bofh.it> <qTepX-7Ua-1@gated-at.bofh.it> <qTg8C-Im-39@gated-at.bofh.it> <qTh4u-1mn-17@gated-at.bofh.it> <qThea-1qJ-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jan 21, 2016 at 03:41:27PM +0900, Michel Dänzer wrote:
> On 21.01.2016 15:38, Michel Dänzer wrote:
> > On 21.01.2016 14:31, Mario Kleiner wrote:
> >> On 01/21/2016 04:43 AM, Michel Dänzer wrote:
> >>> On 21.01.2016 05:32, Mario Kleiner wrote:
> >>>>
> >>>> So the problem is that AMDs hardware frame counters reset to
> >>>> zero during a modeset. The old DRM code dealt with drivers doing that by
> >>>> keeping vblank irqs enabled during modesets and incrementing vblank
> >>>> count by one during each vblank irq, i think that's what
> >>>> drm_vblank_pre_modeset() and drm_vblank_post_modeset() were meant for.
> >>>
> >>> Right, looks like there's been a regression breaking this. I suspect the
> >>> problem is that vblank->last isn't getting updated from
> >>> drm_vblank_post_modeset. Not sure which change broke that though, or how
> >>> to fix it. Ville?
> >>>
> >>
> >> The whole logic has changed and the software counter updates are now
> >> driven all the time by the hw counter.
> >>
> >>>
> >>> BTW, I'm seeing a similar issue with drm_vblank_on/off as well, which
> >>> exposed the bug fixed by 209e4dbc ("drm/vblank: Use u32 consistently for
> >>> vblank counters"). I've been meaning to track that down since then; one
> >>> of these days hopefully, but if anybody has any ideas offhand...
> >>
> >> I spent the last few hours reading through the drm and radeon code and i
> >> think what should probably work is to replace the
> >> drm_vblank_pre/post_modeset calls in radeon/amdgpu by drm_vblank_off/on
> >> calls. These are apparently meant for drivers whose hw counters reset
> >> during modeset, [...]
> >
> > ... just like drm_vblank_pre/post_modeset. That those were broken is a
> > regression which needs to be fixed anyway. I don't think switching to
> > drm_vblank_on/off is suitable for stable trees.
>
> Even more so since as I mentioned, there is (has been since at least
> about half a year ago) a counter jumping bug with drm_vblank_on/off as well.
Hm, never noticed you reported that. I thought the reason for not picking
up my drm_vblank_on/off patches was that there's a bug in amdgpu userspace
where it tried to use vblank waits on a disabled pipe?
Can you please point me at the vblank on/off jump bug please?
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Vlastimil Babka <vbabka@suse.cz> - 2016-01-15 11:40 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-01-15 13:30 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Vlastimil Babka <vbabka@suse.cz> - 2016-01-15 13:50 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Mario Kleiner <mario.kleiner.de@gmail.com> - 2016-01-16 05:30 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Vlastimil Babka <vbabka@suse.cz> - 2016-01-18 15:10 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Vlastimil Babka <vbabka@suse.cz> - 2016-01-20 21:30 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Mario Kleiner <mario.kleiner.de@gmail.com> - 2016-01-20 21:40 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Michel Dänzer <michel@daenzer.net> - 2016-01-21 04:50 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Mario Kleiner <mario.kleiner.de@gmail.com> - 2016-01-21 06:40 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Michel Dänzer <michel@daenzer.net> - 2016-01-21 07:40 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Michel Dänzer <michel@daenzer.net> - 2016-01-21 07:50 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Daniel Vetter <daniel@ffwll.ch> - 2016-01-21 09:00 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Michel Dänzer <michel@daenzer.net> - 2016-01-21 09:40 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Daniel Vetter <daniel@ffwll.ch> - 2016-01-21 11:10 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Michel Dänzer <michel@daenzer.net> - 2016-01-22 04:10 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-01-22 16:20 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Mario Kleiner <mario.kleiner.de@gmail.com> - 2016-01-22 19:30 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Mario Kleiner <mario.kleiner.de@gmail.com> - 2016-01-23 19:30 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Michel Dänzer <michel@daenzer.net> - 2016-01-25 05:20 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Mario Kleiner <mario.kleiner.de@gmail.com> - 2016-01-25 14:20 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-01-25 14:30 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Mario Kleiner <mario.kleiner.de@gmail.com> - 2016-01-25 14:50 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-01-25 16:00 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Mario Kleiner <mario.kleiner.de@gmail.com> - 2016-01-25 17:40 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Daniel Vetter <daniel@ffwll.ch> - 2016-01-25 20:00 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Mario Kleiner <mario.kleiner.de@gmail.com> - 2016-01-25 20:40 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Daniel Vetter <daniel@ffwll.ch> - 2016-01-25 21:40 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Mario Kleiner <mario.kleiner.de@gmail.com> - 2016-01-25 22:50 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Daniel Vetter <daniel@ffwll.ch> - 2016-01-25 23:10 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Mario Kleiner <mario.kleiner.de@gmail.com> - 2016-01-21 09:30 +0100
Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Vlastimil Babka <vbabka@suse.cz> - 2016-01-21 10:20 +0100
csiph-web