Re: question about samsung/sxgbe/sxgbe_xpcs.c

From	Jεan Sacren <sakiwit@gmail.com>
Newsgroups	linux.kernel
Subject	Re: question about samsung/sxgbe/sxgbe_xpcs.c
Date	2016-01-21 06:20 +0100
Message-ID	<qTfP3-x3-5@gated-at.bofh.it> (permalink)
References	<qSHkm-1Ws-9@gated-at.bofh.it> <qSJ2N-36W-1@gated-at.bofh.it> <qSJFx-3m2-27@gated-at.bofh.it> <qSKif-3QG-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: David Miller <davem@davemloft.net>
Date: Tue, 19 Jan 2016 14:36:28 -0500
>
> From: Julia Lawall <julia.lawall@lip6.fr>
> Date: Tue, 19 Jan 2016 19:54:20 +0100 (CET)

[...]

> > I just wondered.  I was looking at dependencies between networking files.
> > This one stands out because nothing is dependenton it, even the files it
> > is compiled with, and it doesn't contain the usual functions,
> > register_netdev, etc.
> 
> Even with that explanation, this is a bogus situation.
> 
> There are no in-tree callers of this code.  It should be removed until there
> are in-tree users.
> 
> Nobody can figure out if the interface for this is done properly without seeing
> the call sites and how they work.  It is therefore impossible to review this
> code and judge it's design.
> 
> If someone doesn't send me a removal patch, I will remove this code myself.

I have the patch ready.

Do you want me to submit it now during the merge window or wait till
net-next opens up again?

Thread

question about samsung/sxgbe/sxgbe_xpcs.c Julia Lawall <julia.lawall@lip6.fr> - 2016-01-19 17:30 +0100
  Re: question about samsung/sxgbe/sxgbe_xpcs.c Shuah Khan <shuahkhan@gmail.com> - 2016-01-19 19:20 +0100
    Re: question about samsung/sxgbe/sxgbe_xpcs.c Julia Lawall <julia.lawall@lip6.fr> - 2016-01-19 20:00 +0100
      Re: question about samsung/sxgbe/sxgbe_xpcs.c David Miller <davem@davemloft.net> - 2016-01-19 20:40 +0100
        Re: question about samsung/sxgbe/sxgbe_xpcs.c Jεan Sacren <sakiwit@gmail.com> - 2016-01-21 06:20 +0100
          Re: question about samsung/sxgbe/sxgbe_xpcs.c Shuah Khan <shuahkh@osg.samsung.com> - 2016-01-21 15:10 +0100
            Re: question about samsung/sxgbe/sxgbe_xpcs.c David Miller <davem@davemloft.net> - 2016-01-21 20:10 +0100
          Re: question about samsung/sxgbe/sxgbe_xpcs.c David Miller <davem@davemloft.net> - 2016-01-21 19:50 +0100
            Re: question about samsung/sxgbe/sxgbe_xpcs.c Jεan Sacren <sakiwit@gmail.com> - 2016-01-21 20:40 +0100

csiph-web