[PATCH] nohz: fix jiffies warp while switch to low-res nohz mode

From	Wanpeng Li <kernellwp@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] nohz: fix jiffies warp while switch to low-res nohz mode
Date	2016-01-21 04:00 +0100
Message-ID	<qTdDA-7aw-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

After commit 0ff53d096422 ("tick: sched: Force tick interrupt and get rid 
of softirq magic"), next expire time is overwritten by last_jiffies_update 
while switch to low-res nohz mode which leads to jiffies warp. This patch 
fix it by programming ce device the expire time in the future.

Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
---
 kernel/time/tick-sched.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 9cc20af..cea6a0e 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -993,9 +993,9 @@ static void tick_nohz_switch_to_nohz(void)
 	/* Get the next period */
 	next = tick_init_jiffy_update();
 
-	hrtimer_forward_now(&ts->sched_timer, tick_period);
 	hrtimer_set_expires(&ts->sched_timer, next);
-	tick_program_event(next, 1);
+	hrtimer_forward_now(&ts->sched_timer, tick_period);
+	tick_program_event(hrtimer_get_expires(&ts->sched_timer), 1);
 	tick_nohz_activate(ts, NOHZ_MODE_LOWRES);
 }
 
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] nohz: fix jiffies warp while switch to low-res nohz mode Wanpeng Li <kernellwp@gmail.com> - 2016-01-21 04:00 +0100
  Re: [PATCH] nohz: fix jiffies warp while switch to low-res nohz  mode Thomas Gleixner <tglx@linutronix.de> - 2016-01-26 16:30 +0100
    Re: [PATCH] nohz: fix jiffies warp while switch to low-res nohz mode Wanpeng Li <kernellwp@gmail.com> - 2016-01-27 12:40 +0100

csiph-web