Re: [PATCH v2 3/3] mtd: nand: sunxi: add randomizer support

From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/3] mtd: nand: sunxi: add randomizer support
Date	2016-01-23 04:00 +0100
Message-ID	<qTWAG-4Dh-1@gated-at.bofh.it> (permalink)
References	<qBdsl-6oc-3@gated-at.bofh.it> <qBdsm-6oc-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

All three look good, so pushed to l2-mtd.git/next. One comment below:

On Wed, Dec 02, 2015 at 12:01:07PM +0100, Boris Brezillon wrote:

...

> +static u16 sunxi_nfc_randomizer_state(struct mtd_info *mtd, int page, bool ecc)
> +{
> +	const u16 *seeds = sunxi_nfc_randomizer_page_seeds;
> +	int mod = mtd->erasesize / mtd->writesize;

Richard suggested you use the mtd.h helper here. Patch below.

> +
> +	if (mod > ARRAY_SIZE(sunxi_nfc_randomizer_page_seeds))
> +		mod = ARRAY_SIZE(sunxi_nfc_randomizer_page_seeds);
> +
> +	if (ecc) {
> +		if (mtd->ecc_step_size == 512)
> +			seeds = sunxi_nfc_randomizer_ecc512_seeds;
> +		else
> +			seeds = sunxi_nfc_randomizer_ecc1024_seeds;
> +	}
> +
> +	return seeds[page % mod];
> +}

From: Brian Norris <computersforpeace@gmail.com>
Date: Fri, 22 Jan 2016 18:54:02 -0800
Subject: [PATCH] mtd: nand: sunxi: use mtd_div_by_ws() helper

Suggested-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
 drivers/mtd/nand/sunxi_nand.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/sunxi_nand.c b/drivers/mtd/nand/sunxi_nand.c
index 5f700719d5c2..b5ea6b312df0 100644
--- a/drivers/mtd/nand/sunxi_nand.c
+++ b/drivers/mtd/nand/sunxi_nand.c
@@ -624,7 +624,7 @@ static u16 sunxi_nfc_randomizer_step(u16 state, int count)
 static u16 sunxi_nfc_randomizer_state(struct mtd_info *mtd, int page, bool ecc)
 {
 	const u16 *seeds = sunxi_nfc_randomizer_page_seeds;
-	int mod = mtd->erasesize / mtd->writesize;
+	int mod = mtd_div_by_ws(mtd->erasesize, mtd);
 
 	if (mod > ARRAY_SIZE(sunxi_nfc_randomizer_page_seeds))
 		mod = ARRAY_SIZE(sunxi_nfc_randomizer_page_seeds);
-- 
2.7.0.rc3.207.g0ac5344

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 3/3] mtd: nand: sunxi: add randomizer support Brian Norris <computersforpeace@gmail.com> - 2016-01-23 04:00 +0100
  Re: [PATCH v2 3/3] mtd: nand: sunxi: add randomizer support Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-01-23 09:20 +0100
    Re: [PATCH v2 3/3] mtd: nand: sunxi: add randomizer support Brian Norris <computersforpeace@gmail.com> - 2016-01-23 22:00 +0100

csiph-web