Re: [PATCH] hid: add support for Lilliput touchscreen

From	Benjamin Tissoires <benjamin.tissoires@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] hid: add support for Lilliput touchscreen
Date	2016-01-22 23:50 +0100
Message-ID	<qTSGK-24Y-11@gated-at.bofh.it> (permalink)
References	<qEBRv-mG-35@gated-at.bofh.it> <qTnCW-5S1-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jan 21, 2016 at 2:37 PM, Jiri Kosina <jikos@kernel.org> wrote:
> On Fri, 11 Dec 2015, Srinivas Kandagatla wrote:
>
>> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
>> index c6f7a69..4350376 100644
>> --- a/drivers/hid/hid-core.c
>> +++ b/drivers/hid/hid-core.c
>> @@ -2051,6 +2051,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
>>       { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) },
>>       { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) },
>>       { HID_USB_DEVICE(USB_VENDOR_ID_ZYDACRON, USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL) },
>> +     { HID_USB_DEVICE(USB_VENDOR_ID_LILLIPUT, USB_PROD_ID_LILLIPUT) },
>
> Could you please keep the list sorted?
>
>>
>>       { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_PRESENTER_8K_BT) },
>>       { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_NINTENDO, USB_DEVICE_ID_NINTENDO_WIIMOTE) },
>> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
>> index 9024a3d..f87993f 100644
>> --- a/drivers/hid/hid-ids.h
>> +++ b/drivers/hid/hid-ids.h
>> @@ -1055,4 +1055,8 @@
>>  #define USB_DEVICE_ID_RAPHNET_2NES2SNES      0x0002
>>  #define USB_DEVICE_ID_RAPHNET_4NES4SNES      0x0003
>>
>> +/* Lilliput Capacitive TouchScreen */
>> +#define USB_VENDOR_ID_LILLIPUT  0x1391
>> +#define USB_PROD_ID_LILLIPUT    0x2112
>> +
>>  #endif
>> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
>> index 3d664d0..580749e 100644
>> --- a/drivers/hid/hid-multitouch.c
>> +++ b/drivers/hid/hid-multitouch.c
>> @@ -1209,6 +1209,11 @@ static const struct hid_device_id mt_devices[] = {
>>               MT_USB_DEVICE(USB_VENDOR_ID_CJTOUCH,
>>                       USB_DEVICE_ID_CJTOUCH_MULTI_TOUCH_0040) },
>>
>> +     /* Lilliput multitouch panels */
>> +     {  .driver_data = MT_CLS_DEFAULT,

NACK without further explanations.

Why do you need to patch the kernel an already working touchscreen?
MT_CLS_DEFAULT is the default as its name stands, and we do not need
to add a per device entry for it.

Cheers,
Benjamin

>> +             HID_USB_DEVICE(USB_VENDOR_ID_LILLIPUT,
>> +                     USB_PROD_ID_LILLIPUT) },
>> +
>
> This is a bit out of order as well.
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] hid: add support for Lilliput touchscreen Jiri Kosina <jikos@kernel.org> - 2016-01-21 14:40 +0100
  Re: [PATCH] hid: add support for Lilliput touchscreen Benjamin Tissoires <benjamin.tissoires@gmail.com> - 2016-01-22 23:50 +0100

csiph-web